Hello. On 04/10/12 20:09, Lucas De Marchi wrote: > On Thu, Oct 4, 2012 at 11:56 AM, Enlightenment SVN > <no-re...@enlightenment.org> wrote: >> Log: >> e/connman: Check for the correct messages. >> >> Checking two times the same message does not make any sense. The only >> logical >> thing seems to be checking for the properties message here. Leaving the >> wifi >> properties message out as not every setup has wifi. At least on my desktop >> here I don't have /net/connman/technology/wifi so we should not fail >> without >> it. > > You could put wifi props there. We are just checking if the message > was actually created. > > HOWEVER, handling technologies in this function is totally misplaced. > I blame raster for adding this code :). The intention of this function > was to deal with Manager interface. Right approach would be to create > some infra similar to deal with technologies, calling > GetTechnologies() on Manager, monitoring signals etc. > > That said... as it is right now it works, so I'm not changing it. > Soon it will start using edbus, too. > >> >> Dermarchi or Bdilly please cry or fix if this is not as intended. >> (Brought to you by double_condition_check.cocci) > > nice someone is using these scripts... it's a long time since I wrote them
I was happy that some glue already did exist. Just some small changes to get it working with spatch 1.0-rc needed to be done. While this double conditions check is often more cosmetic it did also found some memory corruptions problems Daniel and me patched last week. regards Stefan Schmidt ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
