On Mon, Oct 8, 2012 at 10:23 PM, Cedric BAIL <cedric.b...@free.fr> wrote: > On Mon, Oct 8, 2012 at 11:22 PM, Enlightenment SVN > <no-re...@enlightenment.org> wrote: >> Log: >> Wayland_SHM: Add listener to frame callback >> >> This is the method necessary to synchronize Wayland and Evas rendering, >> similar >> to vblank sync that is used in X11. This solves the Wayland SHM render >> issues >> (tearing effect) without the need to add double buffering to the engine. >> >> In a near future, the SHM implementation will feature double (or triple) >> buffering and this syncrhonization mechanism will be changed to be >> optional. >> >> Patch based on the work started by Robert Bradford on ticket #1280 >> http://trac.enlightenment.org/e/ticket/1280 >> >> Signed-off-by: Eduardo Lima (Etrunko) <eduardo.l...@intel.com> > > I am not sure that this patch should have landed in svn. Reading the > bug report, it seems there is some meaning full concern about some > possible dead lock. Another potential problem I see is that animation > are not synchronized with wayland. I think you should have used > ecore_animator_custome_source_tick and friends. Or do you have a good > reason not to use it ?
Yes, although the bug report is related to the EGL engine, this patch affects only the SHM engine. I have talked a lot to Robert and Wayland maintainers and it was clear that the tearing issue could be solved by synchronising the client and compositor, and the way to do it is by having this frame callback scheme. That is the reason why the same patch on that bug report could be used on SHM engine. The issue still remains with EGL though. As I told on the commit message, we are working on proper double/triple buffering implementation on the client side (read ecore/evas), but it demands quite reasonable amount of work on the SHM engine. When it is ready, this frame callback scheme can be made optional or even removed. As for good reasons, the best one would be that now we have smooth scrolling, flips and animations with that engine. :) Best regards, Etrunko > -- > Cedric BAIL > > ------------------------------------------------------------------------------ > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Eduardo de Barros Lima ◤✠◢ ebl...@gmail.com ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
