On Thu, Oct 11, 2012 at 4:56 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Thu, 11 Oct 2012 09:37:37 -0300 Gustavo Sverzut Barbieri > <barbi...@profusion.mobi> said: > > the other eina mempool enignes arenot even compiled by default. in fact all > tat > is compiled by default is one_big, and chained_pool. even passhtrough isnt > compiled by default (should be though), so it doesnt hurt to remove them as > any > code using these could nver have depended on the non-compiled mempool modules > as eina could have been built without and you'd need to fallback anyway.
One thing is to disable something and another to remove something. If any kind of module that can be conditionally compiled is disabled by default, packagers can always provide them as part of another package. Also, I can always compile the modules that I need to make my software work correctly. If my software can not find the buddy allocator or any other allocator and it is mandatory to have it to work, then my software wont work, which is ok, given its hard dependencies. No fallback, no nothing, it just wont work and is ok from my software point of view. But removing the code makes my software to *never* work. Of course, as I said before, I can pick up the svn history, look for it and copy it, or take it from the current "old" eina. I'm fine with it. > >> That's only for single tree EFL. Regular eina will keep it, also svn history >> will keep it for future reference. >> >> I believe that's also happening for Evas engines, just handful will persist >> (SW, GL, fb, x11, wayland, just 32bits). >> >> --Gustavo >> >> Sent from my iPhone >> >> On 11/10/2012, at 06:48, Jorge Luis Zapata Muga <jorgeluis.zap...@gmail.com> >> wrote: >> >> > On Thu, Oct 11, 2012 at 5:01 AM, Gustavo Sverzut Barbieri >> > <barbi...@profusion.mobi> wrote: >> >> On Wednesday, October 10, 2012, Vincent Torri wrote: >> >> >> >>> On Wed, Oct 10, 2012 at 9:57 PM, Enlightenment SVN >> >>> <no-re...@enlightenment.org <javascript:;>> wrote: >> >>>> Log: >> >>>> efl: simplify mempools, nuke some and make remaining statically built. >> >>>> >> >>>> Now we always build the following memory pools statically: >> >>>> - pass_through: calls malloc/free directly, useful to debug. >> >>>> - chained_pool: default for ages. >> >>>> - one_big: used by some embedded systems (should we remove?) >> >>>> >> >>>> Removed: >> >>>> - ememoa_fixed and ememoa_unknown: depends on a separate lib, not >> >>> supported? >> >>>> - buddy: nobody uses it? >> >>> >> >>> please let turran say if he wants buddy or not before nuking it.. >> >> >> >> >> >> Raster said to keep those so did I. Everything else was removed. >> > >> > Well, if it is removed I guess I'll need to put in another place, >> > given that the eina's mempools can be created outside eina, there wont >> > be any problem. Even so, would be nice to be informed whenever a >> > decision like this takes place. Raster sent a mail to the ml but I >> > thought he was only referring to the configure option, not the code >> > itself. >> > >> > >> >> >> >> >> >>> >> >>> Vincent >> >>> >> >>>> >> >>>> NOTE: we do not need the src/modules/eina/mp/*/Makefile.am anymore >> >>>> since they are statically built. But I'll keep these and the >> >>>> references in src/modules/eina/mp/Makefile.am >> >>>> >> >>>> >> >>>> >> >>>> Author: barbieri >> >>>> Date: 2012-10-10 12:57:53 -0700 (Wed, 10 Oct 2012) >> >>>> New Revision: 77792 >> >>>> Trac: http://trac.enlightenment.org/e/changeset/77792 >> >>>> >> >>>> Removed: >> >>>> trunk/efl/src/modules/eina/mp/buddy/ >> >>> trunk/efl/src/modules/eina/mp/ememoa_fixed/ >> >>> trunk/efl/src/modules/eina/mp/ememoa_unknown/ >> >>> trunk/efl/src/modules/eina/mp/fixed_bitmap/ >> >>>> Modified: >> >>>> trunk/efl/configure.ac trunk/efl/src/lib/eina/Makefile.am >> >>> trunk/efl/src/lib/eina/eina_mempool.c >> >>> trunk/efl/src/lib/eina/eina_mempool.h >> >>> trunk/efl/src/modules/eina/mp/Makefile.am >> >>>> >> >>>> Modified: trunk/efl/configure.ac >> >>>> =================================================================== >> >>>> --- trunk/efl/configure.ac 2012-10-10 19:36:36 UTC (rev 77791) >> >>>> +++ trunk/efl/configure.ac 2012-10-10 19:57:53 UTC (rev 77792) >> >>>> @@ -343,23 +343,7 @@ >> >>>> fi >> >>>> >> >>>> # Choose best memory pool >> >>>> -AC_ARG_ENABLE([default-mempool], >> >>>> - [AC_HELP_STRING([--enable-default-mempool], [Default memory >> >>> allocator could be faster for some computer. @<:@default=disabled@:>@])], >> >>>> - [ >> >>>> - if test "x${enableval}" = "xyes"; then >> >>>> - have_default_mempool="yes" >> >>>> - else >> >>>> - have_default_mempool="no" >> >>>> - fi >> >>>> - ], >> >>>> - [have_default_mempool="no"]) >> >>>> - >> >>>> -AC_MSG_CHECKING([whether to use default mempool allocator]) >> >>>> -AC_MSG_RESULT([${have_default_mempool}]) >> >>>> - >> >>>> -if test "x${have_default_mempool}" = "xyes" ; then >> >>>> - EINA_CONFIGURE_DEFAULT_MEMPOOL="#define EINA_DEFAULT_MEMPOOL" >> >>>> -fi >> >>>> +EINA_CONFIGURE_DEFAULT_MEMPOOL="#define EINA_DEFAULT_MEMPOOL" >> >>>> AC_SUBST([EINA_CONFIGURE_DEFAULT_MEMPOOL]) >> >>>> >> >>>> ### Checks for programs >> >>>> @@ -431,36 +415,11 @@ >> >>>> fi >> >>>> >> >>>> ## Modules >> >>>> - >> >>>> -# Check ememoa memory pool library >> >>>> - >> >>>> -AC_ARG_ENABLE([ememoa], >> >>>> - [AC_HELP_STRING([--enable-ememoa], [build ememoa memory pool module >> >>> @<:@default=yes@:>@])], >> >>>> - [ >> >>>> - if test "x${enableval}" = "xyes" ; then >> >>>> - enable_ememoa="yes" >> >>>> - else >> >>>> - enable_ememoa="no" >> >>>> - fi >> >>>> - ], >> >>>> - [enable_ememoa="yes"]) >> >>>> - >> >>>> -AC_MSG_CHECKING([whether to use ememoa for memory pool]) >> >>>> -AC_MSG_RESULT([${enable_ememoa}]) >> >>>> - >> >>>> -if test "x${enable_ememoa}" = "xyes" ; then >> >>>> - PKG_CHECK_MODULES([EMEMOA], >> >>>> - [ememoa >= 0.0.26 ], >> >>>> - [enable_ememoa="yes"], >> >>>> - [enable_ememoa="no"]) >> >>>> -fi >> >>>> - >> >>>> if ! test "x${requirements_pc_deps_eina}" = "x" ; then >> >>>> PKG_CHECK_MODULES([EINA], [${requirements_pc_deps_eina}]) >> >>>> fi >> >>>> >> >>>> >> >>>> - >> >>>> ## Examples >> >>>> >> >>>> # TODO: add once ecore-evas is merged: >> >>>> @@ -596,26 +555,11 @@ >> >>>> AM_CONDITIONAL([EINA_ON_OFF_THREADS], [! test >> >>> "x${efl_have_on_off_threads}" = "xno"]) >> >>>> >> >>>> ### Modules >> >>>> +EINA_CHECK_MODULE([chained-pool], [static], [chained pool]) >> >>>> +EINA_CHECK_MODULE([pass-through], [static], [pass through]) >> >>>> +EINA_CHECK_MODULE([one-big], [static], [one big]) >> >>>> >> >>>> -if test "x${have_default_mempool}" = "xyes" ; then >> >>>> - enable_chained_pool="no" >> >>>> - enable_pass_through=enlightenment-devel mailing list >> >>> enlightenment-devel@lists.sourceforge.net <javascript:;> >> >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> >> >> >> >> -- >> >> Gustavo Sverzut Barbieri >> >> http://profusion.mobi embedded systems >> >> -------------------------------------- >> >> MSN: barbi...@gmail.com >> >> Skype: gsbarbieri >> >> Mobile: +55 (19) 9225-2202 >> >> ------------------------------------------------------------------------------ >> >> Don't let slow site performance ruin your business. Deploy New Relic APM >> >> Deploy New Relic app performance management and know exactly >> >> what is happening inside your Ruby, Python, PHP, Java, and .NET app >> >> Try New Relic at no cost today and get our sweet Data Nerd shirt too! >> >> http://p.sf.net/sfu/newrelic-dev2dev >> >> _______________________________________________ >> >> enlightenment-devel mailing list >> >> enlightenment-devel@lists.sourceforge.net >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> > ------------------------------------------------------------------------------ >> > Don't let slow site performance ruin your business. Deploy New Relic APM >> > Deploy New Relic app performance management and know exactly >> > what is happening inside your Ruby, Python, PHP, Java, and .NET app >> > Try New Relic at no cost today and get our sweet Data Nerd shirt too! >> > http://p.sf.net/sfu/newrelic-dev2dev >> > _______________________________________________ >> > enlightenment-devel mailing list >> > enlightenment-devel@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> ------------------------------------------------------------------------------ >> Don't let slow site performance ruin your business. Deploy New Relic APM >> Deploy New Relic app performance management and know exactly >> what is happening inside your Ruby, Python, PHP, Java, and .NET app >> Try New Relic at no cost today and get our sweet Data Nerd shirt too! >> http://p.sf.net/sfu/newrelic-dev2dev >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > ------------------------------------------------------------------------------ > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
