On Sat, 6 Oct 2012 23:14:43 +0400 Igor Murzov <e-m...@date.by> said:
> Hi list.
>
> There are several suspicious code snippets in E, that
> look much like copy&paste errors, but I don't know how
> to properly fix those errors. Maybe someone experienced
> could look into these.
>
> #1: src/bin/e_backlight.c#n496
> ----------------------------------------
> if ((e_config->backlight.sysdev) &&
> (!strcmp(e_config->backlight.sysdev, f)))
> bl_sysval = eina_stringshare_add(f);
> else
> bl_sysval = eina_stringshare_add(f);
> ----------------------------------------
you're right here... the else shoudl go as its handled by the 2nd pass walk
to handle the no specific device case.
> #2: src/bin/e_gadcon.c#n2988
> ----------------------------------------
> if (e_gadcon_layout_orientation_get(gc->o_container))
> e_gadcon_layout_pack_request_set(o, gcc->config.pos,
> gcc->config.size);
> else
> e_gadcon_layout_pack_request_set(o, gcc->config.pos,
> gcc->config.size);
> ----------------------------------------
this i suspect was just pedantic copy & paste because everything handles
orientation slightly differently - or almost... except this. harmless, but can
be fixed.
> #3: src/bin/e_border.c#n5765
> ----------------------------------------
> if (e->mode == ECORE_X_EVENT_MODE_GRAB)
> {
> if (e->detail == ECORE_X_EVENT_DETAIL_POINTER) return
> ECORE_CALLBACK_PASS_ON; }
> else if (e->mode == ECORE_X_EVENT_MODE_UNGRAB)
> {
> if (e->detail == ECORE_X_EVENT_DETAIL_POINTER) return
> ECORE_CALLBACK_PASS_ON; }
> ----------------------------------------
this i definitely know is a case of "user to have differing behaviour in the
past and has converged to the same behaviour". this should stay in case it has
to change in future. it's easier to handler like switch cases.
>
> -- Igor
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) ras...@rasterman.com
------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
