Thank you for explanation. But still strange. Even if the content were visible, if the content is into the item layout, then the content should be invisible also since the item layout is invisible.
maybe something another factor affects this to be weird. ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Bruno Dilly"<bdi...@profusion.mobi> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2012-10-17 (수) 02:57:39 Subject: Re: [E-devel] E SVN: bdilly trunk/elementary/src/lib On Tue, Oct 16, 2012 at 12:07 PM, ChunEon Park <hermet>@naver.com> wrote: > How could the item which is created right before added to another container? > item and content is different. Right, I was talking about the content. Ricardo was trying to use the naviframe adding items before and reported some issues. 1) It was segfaulting 2) After segfault was fixed, that they were kept visible, so I've tried to quickly fix it. He tested the commits and said they worked, but actually I never tested anything (my bad). I've reviewed the code here and you seems correct. Ricardo said he doesn't have the code he tested anymore, so I can't do anything else then reverting this commit. Thanks for spotting this. > > ------------------------------------ > -Regards, Hermet- > -----Original Message----- > From: "Bruno Dilly"<bdilly>@profusion.mobi> > To: "Enlightenment developer > list"<enlightenment-devel>@lists.sourceforge.net>; > Cc: > Sent: 2012-10-16 (화) 23:44:35 > Subject: Re: [E-devel] E SVN: bdilly trunk/elementary/src/lib > > On Mon, Oct 15, 2012 at 11:08 PM, ChunEon Park <hermet>@naver.com> wrote: >> This commit looks invalid acutally. Those added items were still invisible. > > It depends. > The item could have been added to another container previously that > changed its visibility, > or even the library user showed it explicitly. > > Sure, the user could be warned that he should always add hidden > objects, otherwise naviframe would be broken, but it's easier to just > hide the > items that shouldn't be visible, imo. > >> >> >> ------------------------------------ >> -Regards, Hermet- >> -----Original Message----- >> From: "Enlightenment SVN"<no-reply>@enlightenment.org> >> To: <enlightenment-svn>@lists.sourceforge.net>; >> Cc: >> Sent: 2012-10-16 (화) 01:26:22 >> Subject: E SVN: bdilly trunk/elementary/src/lib >> >> Log: >> elementary: hide naviframe itens added but not on top >> >> >> >> >> Author: bdilly >> Date: 2012-10-15 09:26:22 -0700 (Mon, 15 Oct 2012) >> New Revision: 78006 >> Trac: http://trac.enlightenment.org/e/changeset/78006 >> >> Modified: >> trunk/elementary/src/lib/elc_naviframe.c >> >> Modified: trunk/elementary/src/lib/elc_naviframe.c >> =================================================================== >> --- trunk/elementary/src/lib/elc_naviframe.c2012-10-15 16:26:11 UTC (rev >> 78005) >> +++ trunk/elementary/src/lib/elc_naviframe.c2012-10-15 16:26:22 UTC (rev >> 78006) >> @@ -1330,6 +1330,8 @@ >> (sd->stack, EINA_INLIST_GET(it), >> EINA_INLIST_GET(((Elm_Naviframe_Item *)before))); >> >> + evas_object_hide(VIEW(it)); >> + >> elm_layout_sizing_eval(obj); >> >> return (Elm_Object_Item *)it; >> @@ -1366,6 +1368,8 @@ >> evas_object_show(VIEW(it)); >> evas_object_hide(VIEW(after)); >> } >> + else >> + evas_object_hide(VIEW(it)); >> >> elm_layout_sizing_eval(obj); >> >> >> >> ------------------------------------------------------------------------------ >> Don't let slow site performance ruin your business. Deploy New Relic APM >> Deploy New Relic app performance management and know exactly >> what is happening inside your Ruby, Python, PHP, Java, and .NET app >> Try New Relic at no cost today and get our sweet Data Nerd shirt too! >> http://p.sf.net/sfu/newrelic-dev2dev >> _______________________________________________ >> enlightenment-svn mailing list >> enlightenment-...@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >> ------------------------------------------------------------------------------ >> Don't let slow site performance ruin your business. Deploy New Relic APM >> Deploy New Relic app performance management and know exactly >> what is happening inside your Ruby, Python, PHP, Java, and .NET app >> Try New Relic at no cost today and get our sweet Data Nerd shirt too! >> http://p.sf.net/sfu/newrelic-dev2dev >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > -- > Bruno Dilly > Senior Developer > ProFUSION embedded systems > http://profusion.mobi > > ------------------------------------------------------------------------------ > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Bruno Dilly Senior Developer ProFUSION embedded systems http://profusion.mobi ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
