It should be scrolled only when the widget is intended to be scrolled. This issue was introduced after elementary refactoring. I fixed this by not scrolling in normal case and scroll the widget only when it is required to be scrolled such as entry. While I was fixing this code, I found entry focus scrolling is broken. This also needs to be fixed.
Special thanks to bluezery and woohyun. Thanks. Daniel Juyung Seo (SeoZ) On Wed, Oct 17, 2012 at 4:39 PM, Carsten Haitzler <[email protected]> wrote: > On Wed, 17 Oct 2012 13:48:45 +0900 Daniel Juyung Seo <[email protected]> > said: > >> I applied bluezery's patch partially. >> We should fix the focus issue. This can be reproduced easily with >> elementary_test -> "Genlist Full Widget" test. >> Scroll the genlist and click any button inside genlist. Genlist will >> be scrolled to the top. > > this is indeed insanely annoying. there are 2 issues at hand here: > > 1. the focus region is wrong. quite simply. the focused object eg is the last > button i pressed > 2. it shouldnt be jumping region on clikc of the scroller etc. when the > scroller ALREADY has focus. (or well is the parent of an already focused > widget). > >> Thanks. >> >> Daniel Juyung Seo (SeoZ) >> >> On Wed, Oct 17, 2012 at 11:35 AM, Daniel Juyung Seo >> <[email protected]> wrote: >> > Well this is a big issue. We should fix this first rather than fixing >> > this in test code. >> > Glima do you have an idea? >> > >> > Thanks. >> > >> > Daniel Juyung Seo (SeoZ) >> > >> > On Tue, Oct 16, 2012 at 7:57 PM, Bluezery <[email protected]> wrote: >> >> Dear all, >> >> >> >> This is patch for fixing map test application's weird behavior. >> >> You can see this bug after zooming 3-4 times and clicking right mouse >> >> button to show elm_menu and click menu item or outside of the menu. >> >> Map is always moved to 0, 0 axis. >> >> >> >> I have found the reason. >> >> In _elm_widget_focus_region_show() (elm_widget.c), When a widget >> >> object has scroller interface and children object, scroller is moved >> >> if children object get focused. I think that this is only for entry >> >> widget used inside scroller because on_focus_region() is only >> >> implemented in entry. (entry is focused inside scroller then scroller >> >> is also moved to show entry.) >> >> >> >> This is not for elm_map, elm_genlist, elm_gengrid, etc. Also widget >> >> implement on_focus_region() but It set x, y as 0, 0. So elm_map is >> >> moved to 0, 0 when elm_menu (children of map) is focused. >> >> Actually elm_widget_focus_region_get(obj, &x, &y, &w, &h) for the >> >> menu object can not give the content position inside parent's >> >> scroller. Only parent object (has scroller) can know the children >> >> object's region inside scroller. >> >> >> >> I think that this is not for all the case. My solutions are ... >> >> 1) Scroller movement should not be done for only parent and children >> >> relation they have. >> >> Scroller movement is specified such as API something like >> >> elm_scroller_focus_move_set (map, menu) . >> >> Only in this case, scroller can be moved. >> >> >> >> 2) focus region get interface should be implemented in pan smart >> >> scroller object. >> >> So focus region get hook of scroller interface is called when children >> >> objects get focused. >> >> And scrollable object calculate children's region to show it. >> >> >> >> Anyway, I attach temporary fix for this. >> >> Please review this patch. >> >> >> >> >> >> BRs, >> >> Kim. >> >> >> >> -- >> >> BRs, >> >> Kim. >> >> >> >> ------------------------------------------------------------------------------ >> >> Don't let slow site performance ruin your business. Deploy New Relic APM >> >> Deploy New Relic app performance management and know exactly >> >> what is happening inside your Ruby, Python, PHP, Java, and .NET app >> >> Try New Relic at no cost today and get our sweet Data Nerd shirt too! >> >> http://p.sf.net/sfu/newrelic-dev2dev >> >> _______________________________________________ >> >> enlightenment-devel mailing list >> >> [email protected] >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> >> >> ------------------------------------------------------------------------------ >> Everyone hates slow websites. So do we. >> Make your web apps faster with AppDynamics >> Download AppDynamics Lite for free today: >> http://p.sf.net/sfu/appdyn_sfd2d_oct >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] > ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
