So this usage is not proper?

Daniel Juyung Seo (SeoZ)

On Sun, Oct 21, 2012 at 4:36 PM, Michael Blumenkrantz
<[email protected]> wrote:
> On Sun, 21 Oct 2012 16:35:15 +0900
> Daniel Juyung Seo <[email protected]> wrote:
>
>> But e_icon_object_set() is deprecated.
>>
>> Daniel Juyung Seo (SeoZ)
>>
>> On Sun, Oct 21, 2012 at 4:27 PM, Michael Blumenkrantz
>> <[email protected]> wrote:
>> > On Sun, 21 Oct 2012 16:04:39 +0900
>> > Daniel Juyung Seo <[email protected]> wrote:
>> >
>> >> Dear discomfitor,
>> >> I found another use case for e_icon_object_set.
>> >>
>> >>    it->o_proxy = e_icon_add(ng->evas);
>> >>    o = evas_object_image_add(ng->evas);
>> >>    evas_object_image_source_set(o, it->base.obj);
>> >>    evas_object_resize(o, 128, 128);
>> >>    evas_object_image_fill_set(o, 0,0,128,128);
>> >>    e_icon_object_set(it->o_proxy, o);
>> >>
>> >> They are from the line 687 of E-MODULES-EXTRA/engage/src/ng_gadcon.c.
>> >> How can I implement this without using e_icon_object_set?
>> >>
>> >> Daniel Juyung Seo (SeoZ)
>> >>
>> >> On Fri, Jul 20, 2012 at 4:52 PM, Enlightenment SVN
>> >> <[email protected]> wrote:
>> >> > Log:
>> >> > finally kill off the last of the e_icon_object_set uses;
>> >> >   this function was being abused in 100% of cases to do something other
>> >> > than the intended use of just setting an evas image into an e_icon. I've
>> >> > added e_icon_edje_object_set which is the edje version and will,
>> >> > hopefully, make things more clear and avoid confusion in the future
>> >> > e_widget_image now calls the proper e_icon functions and is far less
>> >> > likely to trigger a magic failure
>> >> >
>> >> >
>> >> > Author:       discomfitor
>> >> > Date:         2012-07-20 00:52:53 -0700 (Fri, 20 Jul 2012)
>> >> > New Revision: 74213
>> >> > Trac:         http://trac.enlightenment.org/e/changeset/74213
>> >> >
>> >> > Modified:
>> >> >   trunk/e/src/bin/e_icon.c trunk/e/src/bin/e_icon.h
>> >> > trunk/e/src/bin/e_widget_image.c trunk/e/src/bin/e_widget_image.h
>> >
>> > that is a correct usage of e_icon
>
> and engage is an unsupported module

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to