On Mon, Oct 22, 2012 at 11:52 PM, Gustavo Sverzut Barbieri <[email protected]> wrote: > On Mon, Oct 22, 2012 at 7:45 PM, Vincent Torri <[email protected]> > wrote: >> On Mon, Oct 22, 2012 at 11:40 PM, Gustavo Sverzut Barbieri >> <[email protected]> wrote: >>> On Mon, Oct 22, 2012 at 7:31 PM, Enlightenment SVN >>> <[email protected]> wrote: >>>> -# TODO: really? do we need this? it's a local eina! >>>> requirements_pc_eo="eina >= 1.7.99" >>> >>> this comment was useful, and the problem it spotted is not solved by >>> removing it. >>> >>> right now we'll provide eo and eina from inside the same source >>> package, then this test is not required (>1.7.99). Even if it was, it >>> should use the current version from variable. >>> >>> more over this will make eo check, during configure time, for >>> installed pkg-config file... but it should NOT, as we did not install >>> our local eina.pc (we're at ./configure). >>> >>> when we compile eo, we know we have eina, and it's a local eina. >>> >>> but when the user runs "pkg-config --libs --cflags eo", we DO WANT >>> eina.pc to be looked up, then we need "Requires.private: eina" >> >> but requirements_pc_eo IS ONLY for eina.pc, not for a check on the local eina >> >> Vincent >> >>> >>> actually for eo this doesn't matter, but for eet it's wrong as you can see >>> in: >>> >>> >>> requirements_pc_eet="eina >= 1.7.99 ${requirements_pc_eet}" >>> >>> PKG_CHECK_MODULES([EET], [${requirements_pc_deps_eet}]) > > sigh, I didn't notice the variables are different, there is a "deps" > inside the name that went unnoticed. > > anyway, the variable with the version is a better fit instead of 1.7.99
indeed, i'll fix that Vincent ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
