When this change can be pushed to svn? ------- Original Message ------- Sender : Daniel Juyung Seo<[email protected]> Date : Dec 06, 2012 00:48 (GMT+09:00) Title : Re: [E-devel] [Elm_colorselector]: saturation bar change from low to high
On Wed, Dec 5, 2012 at 10:49 PM, SHILPA ONKAR SINGH < [email protected]> wrote: > > basically this patch does not cause API break. what it does is make > changes in theme. > > The saturation image used in colorselector is inverted in this patch. > so that value change happens from low to high and ofcourse code is > also > changed accordingly. > so currently default theme is changed. Similar changes needs to be > done > in > other themes as well. > We call this 'theme api break'. After the official release we can't break theme api either. You can fix all the themes in trunk but they are not all the elm themes in this world. There must be some broken themes outside. For more information, I think theme api means: - text part names - swallow part names - signal names - behavior - etc Daniel Juyung Seo (SeoZ) > > Only the image used for saturation bar needs to be > inverted/changed/modified. > There is no API break but only change of image. > > Please let me know if this is being considered as theme break? > > > ------- Original Message ------- > > Sender : SHILPA ONKAR SINGH Lead > Engineer/SISO-Mobile Protocols & Platforms/Samsung Electronics > > Date : Dec 05, 2012 22:35 (GMT+09:00) > > Title : Re: [E-devel] [Elm_colorselector]: saturation bar change from > low to > high > > > basically this patch does cause API break. what it does is make > changes > in > theme. the saturation image used in colorselector is inverted in > this > patch. > so that value change happens from low to high and ofcourse code is > also > changed > accordingly. > so currently default theme is changed similar changes needs to be > done in > other themes > as well. only the image used for saturation bar needs to be inverted. > Please let me know if this is being considered as theme break? > ------- Original Message ------- > Sender : Michael Blumenkrantz > Date : Dec 05, 2012 22:09 (GMT+09:00) > Title : Re: [E-devel] [Elm_colorselector]: saturation bar change > from low > to > high > no released api can be broken until 2.0, regardless of whether it is > theme > or code > On Wed, Dec 5, 2012 at 1:06 PM, Daniel Juyung Seo wrote: > > Daniel Juyung Seo (SeoZ) > > On Dec 5, 2012 7:04 PM, "SHILPA ONKAR SINGH" > > wrote: > > > > > > you mean the existing themes like darkness will break as the > images > used > > for colorselector-saturation > > > is inverted. > > > > yes exactly. > > > > > Can I go ahead and change all themes - > images(color_picker_opacity.png) > > and where are these themes present > > > in e? > > > > colorselector was released in elm 1.7. > > i dont think we can break theme api after the release. > > > > any opinions? > > > > > > > > ------- Original Message ------- > > > Sender : Daniel Juyung Seo > > > Date : Dec 04, 2012 01:46 (GMT+09:00) > > > Title : Re: [E-devel] [Elm_colorselector]: saturation bar change > from > low > > to high > > > > > > Sorry but this will break theme API. > > > Existing elementary themes like darkness, ... will be broken. > > > They will act in a wrong way. > > > > > > Daniel Juyung Seo (SeoZ) > > > > > > On Sat, Dec 1, 2012 at 4:16 PM, SHILPA ONKAR SINGH > wrote: > > > > > > > Hi All, > > > > > > > > Please find attached patch of elm_colorselector. > > > > To maintain consistency with Lightness bar, saturation bar > > > > is modified to be adjusted from low to high and to make it > similar > > > > to other apps like GIMP. > > > > > > > > Change Description: > > > > Elm_colorselector: Saturation bar modified to be adjusted > > > > from low to high. > > > > > > > > Signed-off by: Shilpa Singh([email protected]) > > > > > > > > Thanks & Regards > > > > Shilpa Singh > > > > > > > > > > > > > > > ---------------------------------------------------------------------------- > -- > > > > Keep yourself connected to Go Parallel: > > > > INSIGHTS What's next for parallel hardware, programming and > related > > areas? > > > > Interviews and blogs by thought leaders keep you ahead of the > curve. > > > > http://goparallel.sourceforge.net > > > > _______________________________________________ > > > > enlightenment-devel mailing list > > > > [email protected] > > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > > > > > > > > ---------------------------------------------------------------------------- > -- > > > Keep yourself connected to Go Parallel: > > > BUILD Helping you discover the best ways to construct your > parallel > > projects. > > > http://goparallel.sourceforge.net > > > _______________________________________________ > > > enlightenment-devel mailing list > > > [email protected] > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > ---------------------------------------------------------------------------- > -- > > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > > Remotely access PCs and mobile devices and provide instant support > > Improve your efficiency, and focus on delivering more value-add > services > > Discover what IT Professionals Know. Rescue delivers > > http://p.sf.net/sfu/logmein_12329d2d > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > ---------------------------------------------------------------------------- > -- > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add > services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > [ > http://www.samsung.net/service/ml/AttachController/201212051907710_QKNMBDIF > > .gif?cmd=downdirectly&filepath=/LOCAL/ML/CACHE/s/20121205/BEI0XT4NZ5JE@namo. > [email protected] > &contentType=IMAGE/GIF;charse > t=windows-1252&msgno=145&partno=0.1&foldername=INBOX&msguid=30946] > > > [SeenTimeChecker?do=bfa6c42949d700b52e67e3adcff5f6cfc27e59152a59819f733afbaf > > > 10963357ba777c355c197185c465c2cf80a2b7ef9aba4bb3b2b5ca43ddd7e184e0604d958075 > b6b33f32d245b7f8aafe245478a5f1d21d5ebee74427cf878f9a26ce15a0] > > > [cid:[email protected]] > > > [SeenTimeChecker?do=bfa6c42949d700b53f5a0414e3aee3723f5e7e3a37d9ce09733afbaf > > 10963357ba777c355c197185c465c2cf80a2b7ef9aba4bb3b2b5ca43ddd7e184e0604d958075 > b6b33f32d245b7f8aafe245478a5f1d21d5ebee74427cf878f9a26ce15a0] > > > ------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
