On Thursday, December 6, 2012, Vincent Torri wrote:

> On Thu, Dec 6, 2012 at 7:37 AM, Vincent Torri 
> <[email protected]<javascript:;>>
> wrote:
> > revert !!
> >
> > i want to let it where it was
>
> and it breaks configuration on some debian



Im not reverting, it where it should be. But if the breakages do happen,
I'll fix it.

Btw, the way it was it was rechecking, redefining and even checking for
ancient and unsupported method of inotify. It was also wrong, it's at least
less bad now being centralized, we can fix in a single place and everywhere
will be correct





>
> Vincent
>
> >
> > Vincent
> >
> > On Thu, Dec 6, 2012 at 1:57 AM, Enlightenment SVN
> > <[email protected]> wrote:
> >> Log:
> >> efl: simplify inotify by moving it to common.
> >>
> >>   also deprecate very ancient inotify usage by direct syscall.
> >>
> >>
> >>
> >> Author:       barbieri
> >> Date:         2012-12-05 16:57:29 -0800 (Wed, 05 Dec 2012)
> >> New Revision: 80292
> >> Trac:         http://trac.enlightenment.org/e/changeset/80292
> >>
> >> Modified:
> >>   trunk/efl/configure.ac trunk/efl/m4/eio_check_options.m4
> trunk/efl/src/Makefile_Eio.am trunk/efl/src/lib/eio/eio_monitor_inotify.c
> >>
> >> Modified: trunk/efl/configure.ac
> >> ===================================================================
> >> --- trunk/efl/configure.ac      2012-12-06 00:35:14 UTC (rev 80291)
> >> +++ trunk/efl/configure.ac      2012-12-06 00:57:29 UTC (rev 80292)
> >> @@ -104,6 +104,8 @@
> >>
> >>  #### Default values
> >>
> >> +want_inotify="no"
> >> +
> >>  requirements_pc_crypto=""
> >>  requirements_pc_deps_crypto=""
> >>  requirements_libs_crypto=""
> >> @@ -277,6 +279,11 @@
> >>        MODULE_ARCH="$host_os-$host_cpu-v_maj.v_min.v_mic"
> >>        MODULE_EXT=".dll"
> >>     ;;
> >> +   linux*)
> >> +      want_inotify="yes"
> >> +      MODULE_ARCH="$host_os-$host_cpu-v_maj.v_min.v_mic"
> >> +      MODULE_EXT=".so"
> >> +   ;;
> >>     *)
> >>        MODULE_ARCH="$host_os-$host_cpu-v_maj.v_min.v_mic"
> >>        MODULE_EXT=".so"
> >> @@ -474,6 +481,17 @@
> >>  unistd.h \
> >>  ])
> >>
> >> +have_inotify="no"
> >> +if test "x${want_inotify}" = "xyes" ; then
> >> +   AC_CHECK_HEADER([sys/inotify.h],
> >> +      [
> >> +       AC_DEFINE([HAVE_INOTIFY], [1], [File monitoring with Inotify])
> >> +       have_inotify="yes"
> >> +      ],
> >> +      [have_inotify="no"])
> >> +fi
> >> +AM_CONDITIONAL([HAVE_INOTIFY], [test "x${have_inotify}" = "xyes"])
> >> +
> >>  EFL_CHECK_PATH_MAX
> >>
> >>
> >> @@ -1825,19 +1843,13 @@
> >>
> >>  # cserve2 only works on Linux so far.
> >>
> >> -if test "x${efl_func_shm_open}" = "xno" ; then
> >> +if test "x${efl_func_shm_open}" = "xno" -o "x${have_inotify}" = "xno";
> then
> >>     want_evas_cserve2="no"
> >>  fi
> >>
> >> -if test "x${want_evas_cserve2}" = "xyes" ; then
> >> -   AC_CHECK_HEADERS([sys/epoll.h sys/inotify.h sys/signalfd.h],
> >> -      [],
> >> -      [want_evas_cserve2="no"])
> >> -fi
> >> -
> >> -if test "x${want_evas_cserve2}" = "xyes" ; then
> >> -  AC_DEFINE([EVAS_CSERVE2], [1], [Shared cache server.])
> >> -fi
> >> +AC_DEFINE_IF([EVAS_CSERVE2],
> >> +   [test "x${want_evas_cserve2}" = "xyes"],
> >> +   [1], [Shared cache server.])
> >>  AM_CONDITIONAL([EVAS_CSERVE2], [test "x${want_evas_cserve2}" = "xyes"])
> >>
> >>  ### Configuration
> >> @@ -2368,18 +2380,6 @@
> >>     ],
> >>     [want_poll="yes"])
> >>
> >> -AC_ARG_ENABLE([inotify],
> >> -   [AC_HELP_STRING([--disable-inotify],
> >> -      [disable inotify in th



-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: [email protected]
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to