On Thu, Dec 6, 2012 at 3:08 PM, thomasg <[email protected]> wrote:
> On Thu, Dec 6, 2012 at 12:57 PM, Vincent Torri <[email protected]>wrote:
>
>> so it's a problem with clang. Fix your CC, then
>>
>>
> Is it really?
> dns_rr_foreach is defined as "for (struct dns_rr_i DNS_PP_XPASTE(i,
> __LINE__) = *dns_rr_i_new((P), __VA_ARGS__); ..." in dns.h
> As this is a declaration in the loop, it seems that clang's complaining is
> correct, this is a C99 feature.
>
> So I think, a C99 compiler should be required, even if GCC does not
> complain.

or move the declaration outside the loop...

Vincent

>
>
>>
>>
> On Thu, Dec 6, 2012 at 11:59 AM, Stefan Schmidt <[email protected]>
>> wrote:
>> > Hello.
>> >
>> > On 06/12/12 10:34, Vincent Torri wrote:
>> >> On Thu, Dec 6, 2012 at 11:28 AM, Stefan Schmidt <[email protected]>
>> wrote:
>> >>> Hello.
>> >>>
>> >>> Either during the merge of ecore into efl or during Gustavos changes
>> the
>> >>> std=c99 passing to ecore_con got missing.
>> >>
>> >> adding std=c99 is a BAD idea. Better use AC_PROG_CC_C99 if a c99
>> >> compiler is needed. But honestly, i don't know why it is needed, as
>> >> current compiler check is working for years. So before changing, tell
>> >> me what the error is
>> >
>> > I remember we had problems with that when Mike put in dns.c. Anyway here
>> > are the problems I see when building with Ubuntu clang version
>> > 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0):
>> >
>> > lib/ecore_con/dns.c:878:4: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c:878:4: note: use option -std=c99 or -std=gnu99 to
>> > compile your code
>> > lib/ecore_con/dns.c:885:4: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c:888:5: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c: In function 'dns_p_push':
>> > lib/ecore_con/dns.c:988:28: warning: declaration of '__v' shadows a
>> > previous local [-Wshadow]
>> > lib/ecore_con/dns.c:988:28: warning: shadowed declaration is here
>> [-Wshadow]
>> > lib/ecore_con/dns.c:988:28: warning: declaration of '__x' shadows a
>> > previous local [-Wshadow]
>> > lib/ecore_con/dns.c:988:28: warning: shadowed declaration is here
>> [-Wshadow]
>> > lib/ecore_con/dns.c:1006:28: warning: declaration of '__v' shadows a
>> > previous local [-Wshadow]
>> > lib/ecore_con/dns.c:1006:28: warning: shadowed declaration is here
>> > [-Wshadow]
>> > lib/ecore_con/dns.c:1006:28: warning: declaration of '__x' shadows a
>> > previous local [-Wshadow]
>> > lib/ecore_con/dns.c:1006:28: warning: shadowed declaration is here
>> > [-Wshadow]
>> > lib/ecore_con/dns.c:1022:28: warning: declaration of '__v' shadows a
>> > previous local [-Wshadow]
>> > lib/ecore_con/dns.c:1022:28: warning: shadowed declaration is here
>> > [-Wshadow]
>> > lib/ecore_con/dns.c:1022:28: warning: declaration of '__x' shadows a
>> > previous local [-Wshadow]
>> > lib/ecore_con/dns.c:1022:28: warning: shadowed declaration is here
>> > [-Wshadow]
>> > lib/ecore_con/dns.c:1033:28: warning: declaration of '__v' shadows a
>> > previous local [-Wshadow]
>> > lib/ecore_con/dns.c:1033:28: warning: shadowed declaration is here
>> > [-Wshadow]
>> > lib/ecore_con/dns.c:1033:28: warning: declaration of '__x' shadows a
>> > previous local [-Wshadow]
>> > lib/ecore_con/dns.c:1033:28: warning: shadowed declaration is here
>> > [-Wshadow]
>> > lib/ecore_con/dns.c: In function 'dns_rr_exists':
>> > lib/ecore_con/dns.c:1787:2: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c: In function 'dns_res_merge':
>> > lib/ecore_con/dns.c:5414:2: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c:5421:4: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c:5424:5: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c: In function 'dns_res_glue':
>> > lib/ecore_con/dns.c:5480:3: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c:5496:3: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c: In function 'dns_res_exec':
>> > lib/ecore_con/dns.c:5604:3: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c:5608:3: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c:5806:3: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c:5880:3: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c:5884:3: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c:5893:3: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> > lib/ecore_con/dns.c:6027:3: error: 'for' loop initial declarations are
>> > only allowed in C99 mode
>> >
>> > The warnings are always there so can be ignored for this particular case.
>> >
>> > regards
>> > Stefan Schmidt
>> >
>> >
>> ------------------------------------------------------------------------------
>> > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
>> > Remotely access PCs and mobile devices and provide instant support
>> > Improve your efficiency, and focus on delivering more value-add services
>> > Discover what IT Professionals Know. Rescue delivers
>> > http://p.sf.net/sfu/logmein_12329d2d
>> > _______________________________________________
>> > enlightenment-devel mailing list
>> > [email protected]
>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>>
>> ------------------------------------------------------------------------------
>> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
>> Remotely access PCs and mobile devices and provide instant support
>> Improve your efficiency, and focus on delivering more value-add services
>> Discover what IT Professionals Know. Rescue delivers
>> http://p.sf.net/sfu/logmein_12329d2d
>> _______________________________________________
>> enlightenment-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
> ------------------------------------------------------------------------------
> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> Remotely access PCs and mobile devices and provide instant support
> Improve your efficiency, and focus on delivering more value-add services
> Discover what IT Professionals Know. Rescue delivers
> http://p.sf.net/sfu/logmein_12329d2d
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to