On Thu, Dec 6, 2012 at 5:06 PM, Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote: > On Thursday, December 6, 2012, Leandro Dorileo wrote: > >> On Thu, Dec 06, 2012 at 05:38:36AM -0800, Enlightenment SVN wrote: >> > Log: >> > efl/ecore_file: refactor to be more like eio in providing backends. >> > >> > instead of the previous mess, just define the functions with common >> > names and call the backend that was compiled in, similar to what eio >> > does. >> > >> > also do not be silent on errors, use eina_safety_checks to issue >> warnings. >> > >> > >> > >> > Author: barbieri >> > Date: 2012-12-06 05:38:34 -0800 (Thu, 06 Dec 2012) >> > New Revision: 80360 >> > Trac: http://trac.enlightenment.org/e/changeset/80360 >> > >> > Modified: >> > trunk/efl/configure.ac trunk/efl/src/Makefile_Ecore_File.am >> trunk/efl/src/Makefile_Eio.am >> trunk/efl/src/lib/ecore_file/ecore_file_monitor.c >> trunk/efl/src/lib/ecore_file/ecore_file_monitor_inotify.c >> trunk/efl/src/lib/ecore_file/ecore_file_monitor_poll.c >> trunk/efl/src/lib/ecore_file/ecore_file_monitor_win32.c >> trunk/efl/src/lib/ecore_file/ecore_file_private.h >> > >> > Modified: trunk/efl/configure.ac >> > =================================================================== >> > --- trunk/efl/configure.ac 2012-12-06 13:24:27 UTC (rev 80359) >> > +++ trunk/efl/configure.ac 2012-12-06 13:38:34 UTC (rev 80360) >> > @@ -478,6 +478,13 @@ >> > have_inotify="${ac_cv_header_sys_inotify_h}" >> > AM_CONDITIONAL([HAVE_INOTIFY], [test "x${have_inotify}" = "xyes"]) >> > >> > +have_notify_win32="${have_win32}" >> > +AC_DEFINE_IF([HAVE_NOTIFY_WIN32], >> > + [test "x${have_notify_win32}" = "xyes"], >> > + [File monitoring with Windows notification]) >> >> Missing val argument here... it should be: >> >> AC_DEFINE_IF([HAVE_NOTIFY_WIN32], >> [test "x${have_notify_win32}" = "xyes"], [1], >> [File monitoring with Windows notification]) > > > Oops. Please commit a fix. I'm on the road >
do you test before committing ???? Vincent ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
