On Wed, 12 Dec 2012 15:32:38 +0000 Daniel Willmann <d.willm...@samsung.com>
said:

> Hey, just thought about it some more.
> 
> On 12/12/2012 03:18 PM, Michael Blumenkrantz wrote:
> > On Wed, 12 Dec 2012 15:08:49 +0000
> > Daniel Willmann <d.willm...@samsung.com> wrote:
> > 
> >> On 12/12/2012 03:02 PM, Michael Blumenkrantz wrote:
> >>> stupid though it may seem, released #defines indeed cannot be changed
> >>
> >> I guess I could have seen that.
> >> Will fix in another way then.
> 
> This would mean that you can not add any more types without breaking the
> API for everything that has a sentinel like this, is that correct?
> 
> This doesn't seem to apply to enums, though, as it has been done before
> in Edje_Action_Type with EDJE_ACTION_TYPE_LAST and in
> Evas_Callback_Type with EVAS_CALLBACK_LAST.
> 
> So I gather that this restriction applies to #defines, but not to enums?

wo.. ppl.. let's look at what this define IS... it's a SENTINEL... it is
DESIGNED to change over time (move forward). it's the find of thing where u can
do:

void *slots[EET_LAST];

unsigned int val = get_val();
if (val >= EET_LAST) printf("error - unexpected value\n");
slot[val] = x;

an OLD app running against a NEW eet that may have added new values will
complain that it gets an unexpected value.. it doesnt know how to handle new
values... but thats ok.

so this define CAN change. i think daniels change is fine. it doesnt break
anything as there was no value before it that it now "overwrites" or "loses".

-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to