On Thu, 13 Dec 2012 21:04:51 +0100 Maxime Villard <[email protected]> said:

i put in just fixed for the FILE * leak here on error - the rest i kept. i did
it differently tho.

> Hum, I sent it two weeks ago
> 
> 
> I.  Removed useless 'buf[sizeof(buf) - 1] = 0;', fgets()
>     already does that
> 
> II. Ensure file descriptors are closed before 'goto error'
> 
> III.We don't need to nullcheck before freeing a buf, as it's
>     already done by free()


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    [email protected]


------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to