On Sat, 15 Dec 2012 08:15:54 +0100 Maxime Villard <rusty...@gmx.fr> said:
> Last commit in e_fm_op.c from raster: > wtf? thats like double-free land.. why strdupa at all? nuts! remove > strdupa's and make code consistent with neighbouring code. > > WTF? WTF we need to free lnk_path because _E_FM_OP_ERROR_SEND_WORK() > exits the function. The code with strdupa was good. wait.. wtf. that macro RETURNS! that's nuts! there is no sensible indication that it RETURNS. you read the code and it looks like an awesome place for a double-free - the other macros in efl that return.. have RETURN in them to indicate that... -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
