notifications can be hard to read I guess if you have a desktop bg that's EXACTLY the same color as the notification bg with comp enabled...maybe add a way to increase opacity from config?
On Tue, Dec 18, 2012 at 8:33 AM, Enlightenment SVN < [email protected]> wrote: > Log: > in pursuit of ticket #2017, notifications now show up with the focus > effect to make them slightly more attention-getting; still no change in > opacity > > > Author: discomfitor > Date: 2012-12-18 00:33:04 -0800 (Tue, 18 Dec 2012) > New Revision: 81220 > Trac: http://trac.enlightenment.org/e/changeset/81220 > > Modified: > trunk/e/src/modules/comp/e_mod_comp.c > trunk/e/src/modules/comp/e_mod_comp_cfdata.c > trunk/e/src/modules/comp/e_mod_comp_cfdata.h > > Modified: trunk/e/src/modules/comp/e_mod_comp.c > =================================================================== > --- trunk/e/src/modules/comp/e_mod_comp.c 2012-12-18 08:22:13 UTC > (rev 81219) > +++ trunk/e/src/modules/comp/e_mod_comp.c 2012-12-18 08:33:04 UTC > (rev 81220) > @@ -1618,6 +1618,7 @@ > char buf[4096]; > Eina_List *list = NULL, *l; > Match *m; > + Eina_Bool focus = EINA_FALSE, urgent = EINA_FALSE; > const char *title = NULL, *name = NULL, *clas = NULL, *role = NULL; > Ecore_X_Window_Type primary_type = ECORE_X_WINDOW_TYPE_UNKNOWN; > > @@ -1757,6 +1758,8 @@ > continue; > } > } > + focus = m->focus; > + urgent = m->urgent; > if (m->shadow_style) > { > snprintf(buf, sizeof(buf), "e/comp/%s", > @@ -1797,11 +1800,11 @@ > edje_object_signal_emit(cw->shobj, "e,state,shadow,off", "e"); > } > > - if (cw->bd) > + if (cw->bd || focus || urgent) > { > - if (cw->bd->focused) > + if (focus || (cw->bd && cw->bd->focused)) > edje_object_signal_emit(cw->shobj, "e,state,focus,on", "e"); > - if (cw->bd->client.icccm.urgent) > + if (urgent || (cw->bd && cw->bd->client.icccm.urgent)) > edje_object_signal_emit(cw->shobj, "e,state,urgent,on", "e"); > } > if (cw->visible) > > Modified: trunk/e/src/modules/comp/e_mod_comp_cfdata.c > =================================================================== > --- trunk/e/src/modules/comp/e_mod_comp_cfdata.c 2012-12-18 > 08:22:13 UTC (rev 81219) > +++ trunk/e/src/modules/comp/e_mod_comp_cfdata.c 2012-12-18 > 08:33:04 UTC (rev 81220) > @@ -23,6 +23,8 @@ > E_CONFIG_VAL(D, T, argb, CHAR); > E_CONFIG_VAL(D, T, fullscreen, CHAR); > E_CONFIG_VAL(D, T, modal, CHAR); > + E_CONFIG_VAL(D, T, focus, CHAR); > + E_CONFIG_VAL(D, T, urgent, CHAR); > E_CONFIG_VAL(D, T, shadow_style, STR); > > *conf_edd = E_CONFIG_DD_NEW("Comp_Config", Config); > @@ -106,6 +108,12 @@ > > mat = E_NEW(Match, 1); > cfg->match.popups = eina_list_append(cfg->match.popups, mat); > + mat->name = eina_stringshare_add("_e_popup_notification"); > + mat->shadow_style = eina_stringshare_add("still"); > + mat->focus = 1; > + > + mat = E_NEW(Match, 1); > + cfg->match.popups = eina_list_append(cfg->match.popups, mat); > mat->shadow_style = eina_stringshare_add("popup"); > > cfg->match.borders = NULL; > > Modified: trunk/e/src/modules/comp/e_mod_comp_cfdata.h > =================================================================== > --- trunk/e/src/modules/comp/e_mod_comp_cfdata.h 2012-12-18 > 08:22:13 UTC (rev 81219) > +++ trunk/e/src/modules/comp/e_mod_comp_cfdata.h 2012-12-18 > 08:33:04 UTC (rev 81220) > @@ -56,6 +56,8 @@ > char argb; // used for borders, overrides, popups, menus, 0 == > don't use, 1 == is argb, -1 == not argb > char fullscreen; // used for borders, 0 == don't use, 1 == is > fullscreen, -1 == not fullscreen > char modal; // used for borders, 0 == don't use, 1 == is modal, > -1 == not modal > + char focus; // used for setting focus state (on popups): 1 is > focused, unset is use regular logic > + char urgent; // used for setting urgent state (on popups): 1 is > urgent, unset is use regular logic > }; > > EAPI void e_mod_comp_cfdata_edd_init(E_Config_DD **conf_edd, > E_Config_DD **match_edd); > > > > ------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > enlightenment-svn mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
