Can you also fix elev8? trunk/PROTO/elev8/src/modules/dbus/dbus-message.cc:99: EDBus_Message *msg = edbus_message_signal_new(
Thanks. Daniel Juyung Seo (SeoZ) On Wed, Dec 19, 2012 at 6:38 AM, Enlightenment SVN < [email protected]> wrote: > Log: > edbus: unexport edbus_message_signal_new() > > Signals need to be sent with edbus_service_signal_emit() -- for basic > messages -- or edbus_service_signal_new() + edbus_service_signal_send -- > for complex messages. Otherwise it's possible to send signals that are > not in the service introspection or that have different signatures by > mistake/typo. > > > > Author: lucas > Date: 2012-12-18 13:38:49 -0800 (Tue, 18 Dec 2012) > New Revision: 81311 > Trac: http://trac.enlightenment.org/e/changeset/81311 > > Modified: > trunk/edbus/src/lib/edbus_message.h trunk/edbus/src/lib/edbus_private.h > trunk/edbus/src/lib/edbus_service.c > > Modified: trunk/edbus/src/lib/edbus_message.h > =================================================================== > --- trunk/edbus/src/lib/edbus_message.h 2012-12-18 21:38:43 UTC (rev 81310) > +++ trunk/edbus/src/lib/edbus_message.h 2012-12-18 21:38:49 UTC (rev 81311) > @@ -57,16 +57,6 @@ > */ > EAPI EDBus_Message *edbus_message_method_return_new(const > EDBus_Message *msg) EINA_ARG_NONNULL(1) EINA_WARN_UNUSED_RESULT; > > -/** > - * @brief Constructs a new message representing a signal emission. > - * > - * @param path of the object that was emiting the signal > - * @param interface > - * @param name > - * > - * @return new EDBus_Message, free with edbus_message_unref() > - */ > -EAPI EDBus_Message *edbus_message_signal_new(const char *path, > const char *interface, const char *name) EINA_ARG_NONNULL(1, 2, 3) > EINA_WARN_UNUSED_RESULT; > > /** > * @brief If EDBus_Message is a message error return EINA_TRUE and fills > > Modified: trunk/edbus/src/lib/edbus_private.h > =================================================================== > --- trunk/edbus/src/lib/edbus_private.h 2012-12-18 21:38:43 UTC (rev 81310) > +++ trunk/edbus/src/lib/edbus_private.h 2012-12-18 21:38:49 UTC (rev 81311) > @@ -79,6 +79,7 @@ > void edbus_connection_name_unref(EDBus_Connection > *conn, EDBus_Connection_Name *cn); > EDBus_Signal_Handler *_edbus_signal_handler_add(EDBus_Connection *conn, > const char *sender, const char *path, const char *interface, const char > *member, EDBus_Signal_Cb cb, const void *cb_data); > > +EDBus_Message *edbus_message_signal_new(const char *path, const > char *interface, const char *name) EINA_ARG_NONNULL(1, 2, 3) > EINA_WARN_UNUSED_RESULT; > > #ifdef HAVE_VA_LIST_AS_ARRAY > #define MAKE_PTR_FROM_VA_LIST(arg) ((va_list *)(arg)) > > Modified: trunk/edbus/src/lib/edbus_service.c > =================================================================== > --- trunk/edbus/src/lib/edbus_service.c 2012-12-18 21:38:43 UTC (rev 81310) > +++ trunk/edbus/src/lib/edbus_service.c 2012-12-18 21:38:49 UTC (rev 81311) > @@ -1256,7 +1256,7 @@ > EDBUS_SERVICE_INTERFACE_CHECK_RETVAL(iface, EINA_FALSE); > EINA_SAFETY_ON_NULL_RETURN_VAL(signal_msg, EINA_FALSE); > _edbus_connection_send(iface->obj->conn, signal_msg, NULL, NULL, -1); > - edbus_message_unref(sig); > + edbus_message_unref(signal_msg); > return EINA_TRUE; > } > > > > > ------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > enlightenment-svn mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
