On Thu, Dec 20, 2012 at 12:16 PM, Stefan Schmidt <s.schm...@samsung.com>wrote:
> Hello. > > On 20/12/12 13:53, Gustavo Sverzut Barbieri wrote: > > On Thu, Dec 20, 2012 at 11:41 AM, Enlightenment SVN < > > no-re...@enlightenment.org> wrote: > > > >> Log: > >> efl/eet: Fix certifictate file path detection for eet tests. > >> > >> Author: stefan > >> Date: 2012-12-20 05:41:18 -0800 (Thu, 20 Dec 2012) > >> New Revision: 81453 > >> Trac: http://trac.enlightenment.org/e/changeset/81453 > >> > >> Modified: > >> trunk/efl/src/Makefile_Eet.am > >> > >> Modified: trunk/efl/src/Makefile_Eet.am > >> =================================================================== > >> --- trunk/efl/src/Makefile_Eet.am 2012-12-20 13:39:58 UTC (rev > 81452) > >> +++ trunk/efl/src/Makefile_Eet.am 2012-12-20 13:41:18 UTC (rev > 81453) > >> @@ -99,7 +99,7 @@ > >> -I$(top_srcdir)/src/lib/eina \ > >> -I$(top_builddir)/src/lib/eina \ > >> -I$(top_srcdir)/src/lib/eet \ > >> --DTESTS_SRC_DIR=\"$(top_srcdir)\" \ > >> +-DTESTS_SRC_DIR=\"`pwd`/$(top_srcdir)\" \ > >> @CHECK_CFLAGS@ \ > > > > @EET_CFLAGS@ > >> > > > > makes no sense to use `pwd` in there. Why are you doing that? > > Because without it make distcheck would be failing to find the > certificate files needed during the eet_testsuite run. > > We have three cases here: > 1) build in src tree > 2) buildir != srcdir (we have this on buildbot, I don't know about other > people) > 3) make distcheck > > Before the change above 1 & 2 worked. With the change 1 & 3 works but > not 2. You can see how the dir is used as CERT_DIR in > efl/src/tests/eet/eet_suite.c > > #define CERT_DIR ((*TESTS_SRC_DIR == '/') ? > TESTS_SRC_DIR"/src/tests/eet/" : "src/tests/eet/") > > I changed it with various tests to get something that works for all > cases. Getting tired of it. As you did work on all the autotools stuff > in the merged tree you might have a good idea how to fix it. Be my guest. > > As far as I can see the cert files are in the src dir and also in the > tarball via EXTRA_DIST. I'm fine with any fix on this. (beyond caring) > isn't it better to change eet test suite to get it based on binary location? I'll try -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
