On Fri, Dec 21, 2012 at 4:13 PM, Leandro Dorileo <[email protected]>wrote:
>
> I think it used to depend on geneet.py, but looking at it it seems to not
> call
> geneet.py anywhere, if so the geneet check could be removed as well.
>
> Regards....
>
> On Fri, Dec 21, 2012 at 03:16:04PM +0100, Thomas Gstädtner wrote:
> > I can't see why it would depend on python.
> > ---
> > trunk/PROTO/etrophy/configure.ac | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/trunk/PROTO/etrophy/configure.ac b/trunk/PROTO/etrophy/
> configure.ac
> > index 3f97428..e874e6a 100644
> > --- a/trunk/PROTO/etrophy/configure.ac
> > +++ b/trunk/PROTO/etrophy/configure.ac
> > @@ -83,11 +83,6 @@ AC_PROG_CC
> >
> > EFL_CHECK_DOXYGEN([build_doc="yes"], [build_doc="no"])
> >
> > -# python
> > -
> > -AM_PATH_PYTHON([2.5], , [:])
> > -AM_CONDITIONAL([HAVE_PYTHON], [test "$PYTHON" != : ])
> > -
> > # pkg-config
> >
> > PKG_PROG_PKG_CONFIG
> > --
> > 1.8.0
> >
> >
>
> --
> Leandro Dorileo
> ProFUSION embedded systems
> http://profusion.mobi
>
>
>
Hi Leandro,
you're right, there is no sign of geneet being used actively in etrophy.
So I redid the patch and removed both.
I also attached another patch adding the efl_path_max.m4 macro,
which was called in configure.ac but didn't exist and thus fail.
It's a copy and paste of course (from efreet in this case) :)
--
thomasg
From d6c753f7c6071c07ea91d98364b175fe934a65c9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20Gst=C3=A4dtner?= <[email protected]>
Date: Fri, 21 Dec 2012 16:33:05 +0100
Subject: [PATCH 1/2] etrophy: drop python and geneet dependencies
Both are unused in the etrophy tree.
---
trunk/PROTO/etrophy/configure.ac | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/trunk/PROTO/etrophy/configure.ac b/trunk/PROTO/etrophy/configure.ac
index 3f97428..f0b21da 100644
--- a/trunk/PROTO/etrophy/configure.ac
+++ b/trunk/PROTO/etrophy/configure.ac
@@ -83,11 +83,6 @@ AC_PROG_CC
EFL_CHECK_DOXYGEN([build_doc="yes"], [build_doc="no"])
-# python
-
-AM_PATH_PYTHON([2.5], , [:])
-AM_CONDITIONAL([HAVE_PYTHON], [test "$PYTHON" != : ])
-
# pkg-config
PKG_PROG_PKG_CONFIG
@@ -129,10 +124,6 @@ PKG_CHECK_MODULES([ELEMENTARY],
eina >= 1.7.0
])
-if test "x$HAVE_GENEET" = "xfalse"; then
-AC_MSG_ERROR([*** Geneet not found, make sure geneet.py is in your PATH])
-fi
-
AC_ARG_WITH([edje-cc],
[AC_HELP_STRING([--with-edje-cc=PATH],
[specify a specific path to edje_cc])],
--
1.8.0
From dcdf9630df695e05a3be0580cc4961a830171423 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20Gst=C3=A4dtner?= <[email protected]>
Date: Fri, 21 Dec 2012 16:35:20 +0100
Subject: [PATCH 2/2] etrophy: add efl_path_max m4 macro
The check for it in configure.ac already exists.
---
trunk/PROTO/etrophy/m4/efl_path_max.m4 | 37 ++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 trunk/PROTO/etrophy/m4/efl_path_max.m4
diff --git a/trunk/PROTO/etrophy/m4/efl_path_max.m4
b/trunk/PROTO/etrophy/m4/efl_path_max.m4
new file mode 100644
index 0000000..3ac29bd
--- /dev/null
+++ b/trunk/PROTO/etrophy/m4/efl_path_max.m4
@@ -0,0 +1,37 @@
+dnl Check for PATH_MAX in limits.h, and define a default value if not found
+dnl This is a workaround for systems not providing PATH_MAX, like GNU/Hurd
+
+dnl EFL_CHECK_PATH_MAX([DEFAULT_VALUE_IF_NOT_FOUND])
+dnl
+dnl If PATH_MAX is not defined in <limits.h>, defines it
+dnl to DEFAULT_VALUE_IF_NOT_FOUND if it exists, or fallback
+dnl to using 4096
+
+AC_DEFUN([EFL_CHECK_PATH_MAX],
+[
+
+default_max=m4_default([$1], "4096")
+
+AC_LANG_PUSH([C])
+
+AC_MSG_CHECKING([for PATH_MAX in limits.h])
+AC_COMPILE_IFELSE(
+ [AC_LANG_PROGRAM(
+ [[
+#include <limits.h>
+ ]],
+ [[
+int i = PATH_MAX;
+ ]])],
+ [AC_MSG_RESULT([yes])],
+ [
+ AC_DEFINE_UNQUOTED([PATH_MAX],
+ [${default_max}],
+ [default value since PATH_MAX is not defined])
+ AC_MSG_RESULT([no: using ${default_max}])
+ ])
+
+AC_LANG_POP([C])
+
+])
+dnl end of efl_path_max.m4
--
1.8.0
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
