On Fri, 21 Dec 2012 17:03:01 -0800 "Enlightenment SVN" <[email protected]> wrote:
> Log: > e17/fileman: fix segv: ni->monitor could be NULL > > > Author: jeffdameth > Date: 2012-12-21 17:03:01 -0800 (Fri, 21 Dec 2012) > New Revision: 81629 > Trac: http://trac.enlightenment.org/e/changeset/81629 > > Modified: > trunk/e/src/modules/fileman/e_fwin_nav.c > > Modified: trunk/e/src/modules/fileman/e_fwin_nav.c > =================================================================== > --- trunk/e/src/modules/fileman/e_fwin_nav.c 2012-12-22 00:28:59 UTC (rev > 81628) > +++ trunk/e/src/modules/fileman/e_fwin_nav.c 2012-12-22 01:03:01 UTC (rev > 81629) > @@ -92,7 +92,7 @@ > if (type == EIO_MONITOR_ERROR) > { > //donteven.jpg > - eio_monitor_del(ni->monitor); > + if (ni->monitor) eio_monitor_del(ni->monitor); > ni->monitor = eio_monitor_stringshared_add(ni->path); > return ECORE_CALLBACK_RENEW; > } > @@ -673,6 +673,7 @@ > } > ni->path = eina_stringshare_add(path); > ni->monitor = eio_monitor_stringshared_add(ni->path); > + if (!ni->monitor) DBG("failed to add file monitor: %s", ni->path); > E_LIST_HANDLER_APPEND(ni->handlers, EIO_MONITOR_SELF_DELETED, > _event_deleted, ni); > E_LIST_HANDLER_APPEND(ni->handlers, EIO_MONITOR_SELF_RENAME, > _event_deleted, ni); > E_LIST_HANDLER_APPEND(ni->handlers, EIO_MONITOR_ERROR, _event_deleted, > ni); > > ah that's only a crash if you're using an older release; I fixed it earlier this week to not crash on null ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
