Your patch mixes (and breaks) formatting and logic.
On Fri, Dec 28, 2012 at 7:55 PM, [email protected] < [email protected]> wrote: > please review :) > > Index: evas_object_text.c > =================================================================== > --- evas_object_text.c (revision 81826) > +++ evas_object_text.c (working copy) > @@ -972,10 +972,11 @@ > _evas_object_text_layout(eo_obj, o, text); > eina_stringshare_replace(&o->cur.utf8_text, _text); > o->prev.utf8_text = NULL; > - } > + } > else > { > - if (text) free(text); > + _evas_object_text_layout(eo_obj, o, text); > eina_stringshare_replace(&o->cur.utf8_text, NULL); > } > _evas_object_text_recalc(eo_obj); > > > On Fri, Dec 28, 2012 at 4:16 AM, [email protected] > <[email protected]> wrote: > > On Fri, Dec 28, 2012 at 3:18 AM, Cedric BAIL <[email protected]> > wrote: > >> On Fri, Dec 28, 2012 at 11:07 AM, [email protected] > >> <[email protected]> wrote: > >>> On Fri, Dec 28, 2012 at 2:53 AM, Cedric BAIL <[email protected]> > wrote: > >>>> On Fri, Dec 28, 2012 at 10:48 AM, [email protected] > >>>> <[email protected]> wrote: > >>>>> On Fri, Dec 28, 2012 at 2:19 AM, Cedric BAIL <[email protected]> > wrote: > >>>>>> On Fri, Dec 28, 2012 at 10:08 AM, [email protected] > >>>>>> <[email protected]> wrote: > >>>>>>> i've seen this in evrything for example: first char stays visible > >>>>>>> after deletion until something new is typed > >>>>>> > >>>>>> On what kind of part ? TEXT ? Are you using ellipsis in that case ? > >>>>> > >>>>> yes, it's the input text part. nothing changed in evry for a while. i > >>>>> followed gdb through evry -> edje -> eo -> edje to > >>>>> _edje_object_part_text_raw_set and it all looks correct to that point > >>>>> (on the first sight). maybe something missing in _edje_recalc phase? > >>>> > >>>> That's why I asked about ellipsis. We did a huge change there to make > >>>> it faster, but maybe we did miss some case. Before edje did calculate > >>>> the ellipsis on its own, by trying all possible size until it did fit. > >>>> Now it's done in one pass in Evas directly. That's the main change > >>>> here. > >>> > >>> ah, no the part is not using ellipsis > >> > >> Oh, so I didn't break everything ? That would have been an > >> achievements. Do you have a simple test case ? > > > > i made one: http://www.enlightenment.org/~jeffdameth/test_text.c with > > http://www.enlightenment.org/~jeffdameth/test.edj > > > > when the text is directly replaced in main it works, but not when done > > in the timer cb > > > > > >> -- > >> Cedric BAIL > >> > >> > ------------------------------------------------------------------------------ > >> Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and > >> much more. Get web development skills now with LearnDevNow - > >> 350+ hours of step-by-step video tutorials by Microsoft MVPs and > experts. > >> SALE $99.99 this month only -- learn more at: > >> http://p.sf.net/sfu/learnmore_122812 > >> _______________________________________________ > >> enlightenment-devel mailing list > >> [email protected] > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ > Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and > much more. Get web development skills now with LearnDevNow - > 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts. > SALE $99.99 this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122812 > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Tom. ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122912 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
