On Tue, 1 Jan 2013 08:32:39 +0000 Michael Blumenkrantz <[email protected]> said:
> On Tue, 1 Jan 2013 00:12:10 -0800 > "Enlightenment SVN" <[email protected]> wrote: > > > Log: > > misplaced ERR-- - maybe DBG? > > > > > > > > Author: raster > > Date: 2013-01-01 00:12:09 -0800 (Tue, 01 Jan 2013) > > New Revision: 81945 > > Trac: http://trac.enlightenment.org/e/changeset/81945 > > > > Modified: > > trunk/efl/src/lib/ecore_con/ecore_con.c > > > > Modified: trunk/efl/src/lib/ecore_con/ecore_con.c > > =================================================================== > > --- trunk/efl/src/lib/ecore_con/ecore_con.c 2012-12-31 23:45:24 UTC > > (rev 81944) +++ trunk/efl/src/lib/ecore_con/ecore_con.c 2013-01-01 > > 08:12:09 UTC (rev 81945) @@ -1205,7 +1205,8 @@ > > > > e->client = cl; > > e->error = strdup(error); > > - ERR("%s", error); > > +// givving errors like this is not a good thing - MAYBET his belongs in > > debug... but not err. +// ERR("%s", error); > > cl->event_count = eina_list_append(cl->event_count, e); > > cl->host_server->event_count = eina_list_append > > (cl->host_server->event_count, e); ecore_event_add > > (ECORE_CON_EVENT_CLIENT_ERROR, e, > > (Ecore_End_Cb)_ecore_con_event_client_error_free, cl->host_server); > > > > > > wasn't misplaced. your connection dies... you shouldnt get stderr output. the app deals with it. at best it's DBG. example: set EINA_ERROR_ABORT and u are trying to detect actual code errors.. and your app aborts because it loses connction to another process that exited... that's not an app error. or a library error - it's debug or info at best. err is to indicatiin library/app inconsistencies internally that should not happen and are something to go debug. :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
