On Wed, Jan 2, 2013 at 6:36 PM, Enlightenment SVN <[email protected]> wrote: > Log: > efl: Fix shadow warnings > > Signed-off-by: Mike McCormack <[email protected]> > > Author: mike_m > Date: 2013-01-02 12:36:40 -0800 (Wed, 02 Jan 2013) > New Revision: 82013 > Trac: http://trac.enlightenment.org/e/changeset/82013 > > Modified: > trunk/efl/src/lib/ecore_con/dns.c > > Modified: trunk/efl/src/lib/ecore_con/dns.c > =================================================================== > --- trunk/efl/src/lib/ecore_con/dns.c 2013-01-02 20:36:36 UTC (rev 82012) > +++ trunk/efl/src/lib/ecore_con/dns.c 2013-01-02 20:36:40 UTC (rev 82013) > @@ -949,6 +949,7 @@ > int dns_p_push(struct dns_packet *P, enum dns_section section, const void > *dn, size_t dnlen, enum dns_type type, enum dns_class class, unsigned ttl, > const void *any) { > size_t end = P->end; > int error; > + unsigned short count; > > if ((error = dns_d_push(P, dn, dnlen))) > goto error; > @@ -985,7 +986,8 @@ > if (!P->qd.base && (error = dns_p_study(P))) > goto error; > > - dns_header(P)->qdcount = htons(ntohs(dns_header(P)->qdcount) > + 1); > + count = ntohs(dns_header(P)->qdcount) + 1; > + dns_header(P)->qdcount = htons(count); > > P->qd.end = P->end; > P->an.base = P->end; > @@ -1003,7 +1005,8 @@ > if (!P->an.base && (error = dns_p_study(P))) > goto error; > > - dns_header(P)->ancount = htons(ntohs(dns_header(P)->ancount) > + 1); > + count = ntohs(dns_header(P)->ancount) + 1; > + dns_header(P)->ancount = htons(count); > > P->an.end = P->end; > P->ns.base = P->end; > @@ -1019,7 +1022,8 @@ > if (!P->ns.base && (error = dns_p_study(P))) > goto error; > > - dns_header(P)->nscount = htons(ntohs(dns_header(P)->nscount) > + 1); > + count = ntohs(dns_header(P)->nscount) + 1; > + dns_header(P)->nscount = htons(count); > > P->ns.end = P->end; > P->ar.base = P->end; > @@ -1030,7 +1034,8 @@ > if (!P->ar.base && (error = dns_p_study(P))) > goto error; > > - dns_header(P)->arcount = htons(ntohs(dns_header(P)->arcount) > + 1); > + count = ntohs(dns_header(P)->arcount) + 1; > + dns_header(P)->arcount = ntohs(dns_header(P)->arcount) + 1; >
This last one looks weird, is it really correct? -- Eduardo de Barros Lima ◤✠◢ [email protected] ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
