Sorry, i missed your review. But i fixed it instead. thank you. ------------------------------------
-Regards, Hermet- -----Original Message----- From: "Daniel Juyung Seo"<[email protected]> To: "Enlightenment developer list"<[email protected]>; Cc: Sent: 2013-01-03 (목) 03:28:51 Subject: Re: [E-devel] [Patch] Fix _item_text_set_hook to set part text correctly Dear Jaehyun Cho, thanks for the patch. Your patch looks good and it fixes a bug but I have two comments. 1. the first snprintf is not needed snprintf(buf, sizeof(buf), "elm.text.title"); edje_object_part_text_set(VIEW(it), buf, label); -> edje_object_part_text_set(VIEW(it), "elm.text.title", label); 2. the second snprintf is not needed snprintf(buf, sizeof(buf), "elm.text.subtitle"); edje_object_part_text_set(VIEW(it), buf, label); -> edje_object_part_text_set(VIEW(it), "elm.text.subtitle", label); Can you apply this comments to your patch? Of course I could do this for you but I am just giving you feedbacks for practice. Thanks. Daniel Juyung Seo (SeoZ) On Thu, Jan 3, 2013 at 1:23 AM, 조재현 <jae_hyun_cho>@naver.com> wrote: > Dear all, > > Hello. This is Jaehyun Cho. > The current version of _item_text_set_hook sends the part signal name to > edje_object_part_text_set. (elementary/src/lib/elc_naviframe.c) > To resolve this issue, I sent different arguments to > edje_object_part_text_set for each case. > Please review this patch. > > Thank you, > Jaehyun Cho. > > > ------------------------------------------------------------------------------ > Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery > and much more. Keep your Java skills current with LearnJavaNow - > 200+ hours of step-by-step video tutorials by Java experts. > SALE $49.99 this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122612 > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
