On Wed, 05 Dec 2012 23:34:00 +0000 (GMT) Gwanglim Lee <[email protected]> said:
ooh here it is... your mailer doesnt reply with a reply-to: id so threading loses your mail... as if its a new mail with no thread. :) > Dear Michael, > > Thank you for your kind comments. > I've modified patch according to your review. > > #2. change conditional op to '||' from '&&' - done > #3. change loop conditional - done > for (i = 0; (i < (sizeof(buf) - 1)) && (s[i]); i++) > #9. just call free(class) without null check - done > #12. e_util_strcmp instead of strcmp - done > Thank you for letting me know the e_util_strcmp, it is very useful. :) > > Could you check this patch again? > > Thanks & Regards, > Gwanglim > > ------- Original Message ------- > Sender : Michael Blumenkrantz<[email protected]> > Date : 2012-12-05 20:13 (GMT+09:00) > Title : Re: [E-devel] [PATCH][E] Patch for minor bugs again > > Hi, > > #2 was incorrect, the conditional should simply be changed from && to || > #3 could be (and was) changed to simply modify the loop conditional > > Instead of testing if (x && (!strcmp(X, "string"))), E17 provides the > function e_util_strcmp which can take NULL. > Also it is not necessary to test if (X) before calling free(X); free() will > always accept NULL. > > Otherwise good work! > > On Wed, Dec 5, 2012 at 8:20 AM, Gwanglim Lee <[email protected]> wrote: > > > Dear all, > > > > As I've said before, I'm attached a patch for minor bugs in the e17 again. > > Please take a look at attached patch. > > > > 01. missing E_FREE(wev) if zone is null > > File: src/bin/e_actions.c: 1467 > > Function: ACT_FN_GO_EDGE macro function > > null check of zone and wev, it would be better to separate them. > > > > 02. dead code > > File: src/bin/e_configure.c: 338 > > Function: _e_configure_efreet_desktop_update > > > > 03. array buf might be overwritten by "buf[i] = ' -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and much more. Get web development skills now with LearnDevNow - 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122812 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
