Why is NULL not critical? It's as failure as invalid magic On Tuesday, January 8, 2013, Cedric BAIL wrote:
> On Tue, Jan 8, 2013 at 8:07 PM, Gustavo Sverzut Barbieri > <[email protected] <javascript:;>> wrote: > > No! Why? It's the way I use to detect that with abort + gdb > > We do generate a CRITICAL in all case in Eina_Magic except for when > the pointer is NULL. In which case we trigger an ERR. That's the > current behavior, seems acceptable to me, so I updated the test suite > to reflect that behavior. > > > On Tuesday, January 8, 2013, Enlightenment SVN wrote: > > > >> Log: > >> efl: eina_magic_fail now trigger an ERR on NULL instead of CRITICAL. > >> > >> Updating the test suite. > >> > >> > >> Author: cedric > >> Date: 2013-01-08 01:04:29 -0800 (Tue, 08 Jan 2013) > >> New Revision: 82391 > >> Trac: http://trac.enlightenment.org/e/changeset/82391 > >> > >> Modified: > >> trunk/efl/src/tests/eina/eina_test_magic.c > >> > >> Modified: trunk/efl/src/tests/eina/eina_test_magic.c > >> =================================================================== > >> --- trunk/efl/src/tests/eina/eina_test_magic.c 2013-01-08 08:34:30 UTC > >> (rev 82390) > >> +++ trunk/efl/src/tests/eina/eina_test_magic.c 2013-01-08 09:04:29 UTC > >> (rev 82391) > >> @@ -80,7 +80,7 @@ > >> { > >> struct log_ctx *ctx = data; > >> > >> - ck_assert_int_eq(level, EINA_LOG_LEVEL_CRITICAL); > >> + ck_assert_int_eq(level, EINA_LOG_LEVEL_ERR); /* Level ERR is > triggered > >> for access to NULL instead of level CRITICAL */ > >> ck_assert_str_eq(ctx->msg, fmt); > >> ck_assert_str_eq(ctx->fnc, fnc); > >> ctx->did = EINA_TRUE; > >> > >> > >> > >> > ------------------------------------------------------------------------------ > >> Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS > >> and more. Get SQL Server skills now (including 2012) with LearnDevNow - > >> 200+ hours of step-by-step video tutorials by Microsoft MVPs and > experts. > >> SALE $99.99 this month only - learn more at: > >> http://p.sf.net/sfu/learnmore_122512 > >> _______________________________________________ > >> enlightenment-svn mailing list > >> [email protected] <javascript:;> <javascript:;> > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > >> > > > > > > -- > > Gustavo Sverzut Barbieri > > http://profusion.mobi embedded systems > > -------------------------------------- > > MSN: [email protected] <javascript:;> > > Skype: gsbarbieri > > Mobile: +55 (19) 9225-2202 > > > ------------------------------------------------------------------------------ > > Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS > > and more. Get SQL Server skills now (including 2012) with LearnDevNow - > > 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. > > SALE $99.99 this month only - learn more at: > > http://p.sf.net/sfu/learnmore_122512 > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] <javascript:;> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > -- > Cedric BAIL > > > ------------------------------------------------------------------------------ > Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS > and more. Get SQL Server skills now (including 2012) with LearnDevNow - > 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. > SALE $99.99 this month only - learn more at: > http://p.sf.net/sfu/learnmore_122512 > _______________________________________________ > enlightenment-devel mailing list > [email protected] <javascript:;> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
