Hi,
On Mon, Jan 21, 2013 at 2:53 PM, Rafael Antognolli <antogno...@gmail.com> wrote:
> Hey Ulisses!
>
> On Mon, Jan 21, 2013 at 2:32 PM, Ulisses Furquim <ulis...@profusion.mobi>
> wrote:
>> Hi Antognolli,
>>
>> On Mon, Jan 21, 2013 at 2:05 PM, Enlightenment SVN
>> <no-re...@enlightenment.org> wrote:
>>> Log:
>>> efl/evas: Use "with_opengl" option instead of "gl_flavor_gles".
>>>
>>> The latter got replaced by the former one. This fix the building of some
>>> GL engines when --with-opengl=es is used.
>>>
>>> Author: antognolli
>>> Date: 2013-01-21 08:05:02 -0800 (Mon, 21 Jan 2013)
>>> New Revision: 83040
>>> Trac: http://trac.enlightenment.org/e/changeset/83040
>>>
>>> Modified:
>>> trunk/efl/m4/evas_check_engine.m4
>>>
>>> Modified: trunk/efl/m4/evas_check_engine.m4
>>> ===================================================================
>>> --- trunk/efl/m4/evas_check_engine.m4 2013-01-21 15:37:28 UTC (rev 83039)
>>> +++ trunk/efl/m4/evas_check_engine.m4 2013-01-21 16:05:02 UTC (rev 83040)
>>> @@ -76,7 +76,7 @@
>>> LIBS="$LIBS_save"
>>> fi
>>>
>>> - if test "x${gl_flavor_gles}" = "xyes" ; then
>>> + if test "x${with_opengl}" = "xes" ; then
>>
>> I don't think you meant to replace "xyes" with "xes" too, right?
>
> Yes, I meant to. I know that it became confusing, maybe a better name
> would avoid such confusion, but with_opengl can be "full", "es" or
> "none". That's why I'm testing "x${with_opengl}" = "xes".
>
> Same on the others.
Makes sense. And I was wondering if did test that change. :-)
-- Ulisses
>>> have_dep=no
>>> fi
>>>
>>> @@ -234,7 +234,7 @@
>>> fi
>>> fi
>>>
>>> -if test "x$gl_flavor_gles" = "xyes" ; then
>>> +if test "x${with_opengl}" = "xes" ; then
>>
>> The same here.
>>
>>> have_dep=no
>>> fi
>>>
>>> @@ -470,7 +470,7 @@
>>> #include <GL/glext.h>
>>> ])
>>>
>>> -if test "x$gl_flavor_gles" = "xyes" ; then
>>> +if test "x${with_opengl}" = "xes" ; then
>>
>> And here.
>>
>> Thanks,
>>
>> --
>> Ulisses Furquim
>> ProFUSION embedded systems
>> http://profusion.mobi
>> Mobile: +55 19 9250 0942
>> Skype: ulissesffs
>>
>> ------------------------------------------------------------------------------
>> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
>> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
>> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
>> MVPs and experts. SALE $99.99 this month only -- learn more at:
>> http://p.sf.net/sfu/learnmore_122412
>> _______________________________________________
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
> Thanks for reviewing,
> --
> Rafael Antognolli
> http://antognolli.org/
>
> ------------------------------------------------------------------------------
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. SALE $99.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122412
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Ulisses Furquim
ProFUSION embedded systems
http://profusion.mobi
Mobile: +55 19 9250 0942
Skype: ulissesffs
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
