Hi
I attached 2nd patch accordingly your comment.
If do not set the facter, set the default value in elm transit for checking
tween effect.
BRs
joeyChunEon Park <her...@naver.com> 님이 쓰신 메시지:Hello, Thanks for you interest in
the transit :) I think this is good extension for elm_transit.
Here is my quick review.
1. Don't change enum value ovrder which causes the abi break. Please just
append the additional enum values.
typedef enum
{
ELM_TRANSIT_TWEEN_MODE_LINEAR, /**< Constant speed */
ELM_TRANSIT_TWEEN_MODE_SINUSOIDAL, /**< Starts slow, increase speed
over time, then decrease again
and stop slowly */
ELM_TRANSIT_TWEEN_MODE_DECELERATE, /**< Starts fast and decrease
speed over time */
ELM_TRANSIT_TWEEN_MODE_ACCELERATE, /**< Starts slow and increase speed
over time */
ELM_TRANSIT_TWEEN_MODE_SINUSOIDAL_FACTOR, /**< Start slow, speed up then
slow down at end,
v1 being a power factor */
ELM_TRANSIT_TWEEN_MODE_DECELERATE_FACTOR, /**< Start fast then slow down,
v1 being a power factor */
ELM_TRANSIT_TWEEN_MODE_ACCELERATE_FACTOR, /**< Start slow then speed up,
v1 being a power factor */
ELM_TRANSIT_TWEEN_MODE_DIVISOR_INTERP, /**< Start at gradient v1,
interpolated via power of v2 curve
*/
ELM_TRANSIT_TWEEN_MODE_BOUNCE, /**< Start at 0.0 then "drop" like a ball
bouncing to the ground at 1.0, and
bounce v2 times, with decay factor of v1 */
ELM_TRANSIT_TWEEN_MODE_SPRING /**< Start at 0.0 then "wobble" like a
spring
rest position 1.0, and wobble v2 times,
with decay factor of v1 */
} Elm_Transit_Tween_Mode;
2. Actually, I don't think these are required additionally.
ELM_TRANSIT_TWEEN_MODE_SINUSOIDAL_FACTOR, /**< Start slow, speed up then
slow down at end,
v1 being a power factor */
ELM_TRANSIT_TWEEN_MODE_DECELERATE_FACTOR, /**< Start fast then slow down,
v1 being a power factor */
ELM_TRANSIT_TWEEN_MODE_ACCELERATE_FACTOR, /**< Start slow then speed up,
v1 being a power factor */
We can just use the previous enum values while you can make them consider the
factor values additionally.
If user don't set the factor values(for the exisiting applications), then it
will just work with default values accoriding to the exist work. I think it can
be possible to make previous modes work with and without factors.
3. Do you think "Elm_Transit_Interp" is required? If so why don't the
factor_set() apis don't have the type argument, factor_get() returns the type
value on the other hand?
void elm_transit_tween_mode_factor_set(Elm_Transit *transit, double v1, double
v2);
-> elm_transit_tween_mode_factor_set(Elm_Transit *transit,
Elm_Transit_Interp interp);
or
EAPI Elm_Transit_Interp *elm_transit_tween_mode_factor_get(const Elm_Transit
*transit);
-> EAPI void elm_transit_tween_mode_factor_get(const Elm_Transit *transit,
double *v1, double *v2);
I prefer the later one in EAPI world.
------------------------------------
-Regards, Hermet-
-----Original Message-----
From: "jchanwook"<jchanw...@gmail.com>
To: <enlightenment-devel@lists.sourceforge.net>;
Cc:
Sent: 2013-01-22 (화) 09:09:02
Subject: [E-devel] [Patch] elm_transit feature extenstion
Hi all,
All tween modes are added and you can set the interp.
ELM_TRANSIT_TWEEN_MODE_ACCELERATE_FACTOR
ELM_TRANSIT_TWEEN_MODE_DECELERATE_FACTOR
ELM_TRANSIT_TWEEN_MODE_SINUSOIDAL_FACTOR
ELM_TRANSIT_TWEEN_MODE_DIVISOR_INTERP
ELM_TRANSIT_TWEEN_MODE_BOUNCE
ELM_TRANSIT_TWEEN_MODE_SPRING
EAPI void elm_transit_tween_mode_factor_set(Elm_Transit *transit, double v1,
double v2);
EAPI Elm_Transit_Interp *elm_transit_tween_mode_factor_get(const Elm_Transit
*transit);
Thanks,
Joey
------------------------------------------------------------------------------
Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
and more. Get SQL Server skills now (including 2012) with LearnDevNow -
200+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only - learn more at:
http://p.sf.net/sfu/learnmore_122512
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
