On 30/01/13 17:15, Raphael Kubo da Costa wrote: > A few days ago I was investigating a bug in the EFL WebKit port and > noticed WebKit's and Evas' handling of Fontconfig are somewhat > incompatible: while the evas_font code calls both FcInit() and FcFini() > when on initialization and shutdown, respectively, WebKit keeps some > Fontconfig objects alive until the process exits. In practice, this > means that shutting Evas down will cause FcFini() to assert because > there are objects which have not been properly destroyed. > > This is not really a WebKit-specific problem, as any program which also > uses Fontconfig directly and shuts Evas down before destroying all FC > resources it has allocated is going to crash in the same way. > > Other libraries such as Qt, Pango and Cairo do not explicitly initialize > and shut Fontconfig down. Evas itself got this code in r40242 and was > later adjusted in r45829 and r74870. > > Since we can't completely control the lifetime of all Fontconfig objects > used in client code, I was thinking of doing the same thing as other > libraries do and get rid of the calls to FcInit() and FcFini(). The part > which is really important is not calling FcFini() -- this was already > done for a while in the r45829 which I mentioned. Valgrind will complain > about some "still reachable" memory blocks, but that's not really > important (as raster said in that revision's commit message, "things may > look like they leak in Valgrind - they dont. in reality"). > > Thoughts?
Hey. You only removed code, are you sure we still init everything after your changes? (Sorry, I don't have time to take a look yet). -- Tom. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
