2013/2/19 Carsten Haitzler <ras...@rasterman.com> > On Mon, 18 Feb 2013 21:41:06 +0100 Davide Andreoli <d...@gurumeditation.it > > > said: > > > 2013/2/18 Carsten Haitzler <ras...@rasterman.com> > > > > > On Mon, 11 Feb 2013 22:46:32 +0100 Davide Andreoli < > d...@gurumeditation.it > > > > > > > said: > > > > > > i fixed it. :) > > > > > > > Yes fixed, but spotted an api-design problem: > > color_class_list return a list of string to free()ed > > while text_class_list return a stringshared pointer that need to be > > stringshare_del() > > > > ...also the doc is wrong for the second function > > what to do ? just adjust the docs? > > yeah - this is i guess an api oddity... but reading Edje.h - it's correct. > the > color class list is strduped and needs free()ing and the text class list is > stringshared and needs stringshare_del(). we can't change this at this > stage > without an api/abi break... and docs are right: > > * @return A list of color class names (strings). These strings and > * the list must be free()'d by the caller. > > * @return A list of text class names (strings). These strings are > * stringshares and the list must be free()'d by the caller. > > well it DOES say the strings are stringshares... so thus the logical call > is > stirnghsare_del and the list freed with eina_list_free() for instance. > docs are > not wrong - they are vague though. >
ah, gosh, I didn't noticed the string/stringshare difference in the docs, also if I was searching for that difference :P Indeed it's a little vague and "free()d by the caller" is ambiguous, I will fix that piece of docs > > > > > Hi guys, > > > > I think I found 2 bugs in edje (trunk): > > > > > > > > edje_color_class_list() and edje_text_class_list() always return > > > nothing... > > > > > > > > see a super simple example at: > > > > http://pastebin.com/8dAiaFzR > > > > > > > > looking at the code seems that the 2 functions implementation search > in > > > the > > > > wrong hash, > > > > but I'm not sure... > > > > > > > > can someone give a look please ? > > > > > > > > thanks > > > > > > > > davemds > > > > > > > > ------------------------------------------------------------------------------ > > > > Free Next-Gen Firewall Hardware Offer > > > > Buy your Sophos next-gen firewall before the end March 2013 > > > > and get the hardware for free! Learn more. > > > > http://p.sf.net/sfu/sophos-d2d-feb > > > > _______________________________________________ > > > > enlightenment-devel mailing list > > > > enlightenment-devel@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > > > -- > > > ------------- Codito, ergo sum - "I code, therefore I am" > -------------- > > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
