On 18/02/13 18:41, Martin Jansa wrote: > On Mon, Feb 18, 2013 at 09:36:50AM +0000, Stefan Schmidt wrote: >> Hello. >> >> On 18/02/13 09:21, Tom Hacohen wrote: >>> On 18/02/13 04:02, Daniel Juyung Seo wrote: >>>> And it'll be great if the title includes the first line of commit >>> message. >>>> That should be way more useful. >>>> Thanks. >>> >>> Correct me if I'm wrong, but I'm starting to think you guys would like >>> to see the whole diff in the title. >> >> Come on. Take a step back and look at the commit email subject line as >> we have it right now: >> >> [EGIT] [core/efl] branch master updated. >> 04e660c5c76fa9168be08de1f979a1684c464154 >> >> [EGIT] Might be needed for people that can or want not filter on message >> headers. >> >> [core/efl] Gives the repo. Useful. >> >> branch master updated: I argued before that commit mails should only be >> send for the master branch. Everything else is only interesting for a >> small group of people and they will pull and look at the specific >> branches on their own. >> >> git hash: Not useful in the title I would argue. Gives you zero >> informations about what was changed. Needed in the body for sure, but >> not in the subject. > > OE has IMHO good setup for git commits, and it should be easy to get > their git hook. Messages look like this: > > From: g...@git.openembedded.org > Subject: [oe-commits] Martin Jansa : ca-certificates: upgrade to 20130119 > > Module: meta-openembedded.git > Branch: master > Commit: af0a0dde191acb5725073e30a8a0b42d819233c6 > URL: > http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=af0a0dde191acb5725073e30a8a0b42d819233c6 > > Author: Martin Jansa <martin.ja...@gmail.com> > Date: Mon Feb 11 20:23:51 2013 +0000 > > ca-certificates: upgrade to 20130119 > > * old archive is no longer on upstream URL > > Signed-off-by: Martin Jansa <martin.ja...@gmail.com> > > --- > > whole patch here > > --- > > With this format it's easy to filter emails to different mail foder for > different > branches or modules. > > Cheers, >
We've improved it now, I think it's better. Anyhow could we have their hook? One additional note: our mails (and I bet their as well) have a lot of extra header fields to help users filter the mails. You guys might want to take a look. Cheers, Tom. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
