I forgot to add EFL mailing list. :( ---------- Forwarded message ---------- From: Bluezery <[email protected]> Date: 2013/2/21 Subject: Re: [E-devel] [elementary]map: Fix 1byte invalid read To: Tom Hacohen <[email protected]>
OK, it's from my bad english :) I splited the patch. fix 1byte error & more !! fix_more.patch does nothing when buf allocation failed. 2013/2/21 Tom Hacohen <[email protected]>: > On 21/02/13 11:44, Bluezery wrote: >> >> Why not happens?? >> 1. because eina_simple_xml_parse uses char *, buf should be null >> terminated. So I use memset. >> 2. Because NULL is needed at the end, I add one more byte. >> fread read exact bytes and has no NULL. >> 3. If buf is failed to alloc (very rarely case), it is not need to be >> rewinded. >> >> PS. I found more cases in the map code and I fixed patch again. > > > You didn't understand me correctly. Your patch fixes a valid problem, I was > just explaining what you've mentioned in point #3. I'm saying that you've > changed more things than what you've claimed in the log. > > The rest is a good patch. > > -- > Tom. > -- BRs, Kim. -- BRs, Kim.
map@fix_1byte_error.patch
Description: Binary data
map@fix_more.patch
Description: Binary data
------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
