On Wed, Mar 20, 2013 at 12:38 PM, Cedric BAIL <[email protected]> wrote:
> On Wed, Mar 20, 2013 at 5:36 PM, Mike Blumenkrantz - Enlightenment Git > <[email protected]> wrote: > > discomfitor pushed a commit to branch master. > > > > commit 605f781e3608cf17b03a89acab64c1daa42ea43a > > Author: Mike Blumenkrantz <[email protected]> > > Date: Wed Mar 20 08:33:40 2013 +0000 > > > > dear cedric, > > > > fucking compile things before you commit. > > > > your vengeful buddy, > > mike > > --- > > src/bin/e_sys_l2ping.c | 2 +- > > src/bin/e_sys_main.c | 2 +- > > src/modules/bluez4/e_mod_main.c | 3 +-- > > 3 files changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/src/bin/e_sys_l2ping.c b/src/bin/e_sys_l2ping.c > > index ac826ea..faab77e 100644 > > --- a/src/bin/e_sys_l2ping.c > > +++ b/src/bin/e_sys_l2ping.c > > @@ -10,7 +10,7 @@ > > #endif > > > > double > > -e_sys_l2ping(const char *bluetooth_mac) > > +e_sys_l2ping(const char *bluetooth_mac EINA_UNUSED) > > That is a bad way to silent this warning when you don't have > bluetooth. Now compiler could decide to drop that from the stack as an > optimization and could break for those having bluetooth. > > > { > > #ifdef HAVE_BLUETOOTH > > char send_buf[L2CAP_CMD_HDR_SIZE + 1]; > > diff --git a/src/bin/e_sys_main.c b/src/bin/e_sys_main.c > > index 1805706..70f836c 100644 > > --- a/src/bin/e_sys_main.c > > +++ b/src/bin/e_sys_main.c > > @@ -188,7 +188,7 @@ main(int argc, > > latency = e_sys_l2ping(output); > > > > eina_convert_dtoa(latency, tmp); > > - fprintf(stdout, tmp); > > + fprintf(stdout, "%s\n", tmp); > > WOOT ? Why are you adding a \n here ? It make no sense, that tool is > read by enlightenment on the other side. It is not intended to be read > by human. Tmp is also the output of eina_convert_dtoa it will never > put any % in. Never. There is no point to do that. > > -- > Cedric BAIL > > I added them to silence warnings which you created and never should have committed. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
