On Wed, Mar 27, 2013 at 1:22 AM, Tom Hacohen <[email protected]> wrote:
> On 26/03/13 16:17, Daniel Juyung Seo - Enlightenment Git wrote:
>> seoz pushed a commit to branch master.
>>
>> commit 67f0f9eae1eaae2002e9ed7407b99a10c4f76854
>> Author: Daniel Juyung Seo <[email protected]>
>> Date:   Wed Mar 27 01:17:18 2013 +0900
>>
>>      elm_genlist.c: fixed formatting.
>> ---
>>   src/lib/elm_genlist.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
>> index 8ea1219..6b06cfd 100644
>> --- a/src/lib/elm_genlist.c
>> +++ b/src/lib/elm_genlist.c
>> @@ -3981,8 +3981,8 @@ _access_activate_cb(void *data __UNUSED__,
>>                Elm_Gen_Item *it2;
>>
>>                EINA_LIST_FOREACH_SAFE(sd->selected, l, l_next, it2)
>> -                if (it2 != it)
>> -                  _item_unselect(it2);
>> +               if (it2 != it)
>> +                 _item_unselect(it2);
>>             }
>>           _item_highlight(it);
>>           it->sel_cb(it);
>> @@ -4141,8 +4141,8 @@ _item_mouse_up_cb(void *data,
>>                Elm_Gen_Item *it2;
>>
>>                EINA_LIST_FOREACH_SAFE(sd->selected, l, l_next, it2)
>> -                if (it2 != it)
>> -                  _item_unselect(it2);
>> +               if (it2 != it)
>> +                 _item_unselect(it2);
>>             }
>>           _item_highlight(it);
>>           it->sel_cb(it);
>>
>
> While you are at it, you might as well fix the real issue there, which
> is doing the loop with an if, but without an enclosing {} pair. It can
> be potentially confusing.

Well, it looks like a good suggestion.
Fixed!

Daniel Juyung Seo (SeoZ)

>
> --
> Tom.
>
> ------------------------------------------------------------------------------
> Own the Future-Intel&reg; Level Up Game Demo Contest 2013
> Rise to greatness in Intel's independent game demo contest.
> Compete for recognition, cash, and the chance to get your game
> on Steam. $5K grand prize plus 10 genre and skill prizes.
> Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

------------------------------------------------------------------------------
Own the Future-Intel&reg; Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest.
Compete for recognition, cash, and the chance to get your game 
on Steam. $5K grand prize plus 10 genre and skill prizes. 
Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to