On 27/03/13 08:23, Stefan Schmidt wrote: > Hello. > > On 27/03/13 06:32, Christopher Michael wrote: >> Hi etrunko, >> >> While I am not against this commit, I do feel that it is slightly >> incomplete ... in that there is no "@since" added for this function :/ >> >> dh >> >> On 26/03/13 18:51, Eduardo Lima - Enlightenment Git (Etrunko) wrote: >>> etrunko pushed a commit to branch master. >>> >>> commit 19561c611250352df5bc571e0ec2fa88972e4bdd >>> Author: Eduardo Lima (Etrunko) <[email protected]> >>> Date: Tue Mar 26 15:48:41 2013 -0300 >>> >>> Ecore_Wayland: Add ecore_wl_window_surface_create() API >>> >>> On some use cases, it is necessary to create a new wl_surface >> without >>> associating it to a wl_shell_surface. This new API makes it >> possible. >>> >>> Signed-off-by: Eduardo Lima (Etrunko) <[email protected]> >>> --- >>> src/lib/ecore_wayland/Ecore_Wayland.h | 10 ++++++++++ >>> src/lib/ecore_wayland/ecore_wl_window.c | 15 ++++++++++++--- >>> 2 files changed, 22 insertions(+), 3 deletions(-) >>> >>> diff --git a/src/lib/ecore_wayland/Ecore_Wayland.h >> b/src/lib/ecore_wayland/Ecore_Wayland.h >>> index a610c14..250429e 100644 >>> --- a/src/lib/ecore_wayland/Ecore_Wayland.h >>> +++ b/src/lib/ecore_wayland/Ecore_Wayland.h >>> @@ -635,6 +635,16 @@ EAPI Ecore_Wl_Dnd *ecore_wl_dnd_get(); >>> EAPI Eina_Bool ecore_wl_dnd_start_drag(); >>> EAPI Eina_Bool ecore_wl_dnd_selection_has_owner(Ecore_Wl_Dnd *dnd); >>> >>> +/** >>> + * Returns a wl_surface with no association to any wl_shell_surface. >>> + * >>> + * @param win The window which will use this newly created surface. >>> + * >>> + * @ingroup Ecore_Wl_Window_Group >>> + * @since 1.8 >>> + */ >>> +EAPI struct wl_surface *ecore_wl_window_surface_create(Ecore_Wl_Window >> *win); > > To me it looks as there is one. :) > > regards > Stefan Schmidt
Ahh yes, I stand corrected. I was looking in the other file :/ Guess I should have waited and read the whole thing after some coffee ;) Cheers, dh ------------------------------------------------------------------------------ Own the Future-Intel® Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
