I fixed the type format and add the description. The API name.. I think it maybe have more discussion. For now, I'll let it be.
2013년 4월 1일 월요일에 Daniel Juyung Seo님이 작성: > On Mon, Apr 1, 2013 at 8:55 PM, Gustavo Sverzut Barbieri > <[email protected] <javascript:;>> wrote: > > On Mon, Apr 1, 2013 at 8:45 AM, Daniel Juyung Seo > > <[email protected]<javascript:;> > >wrote: > > > >> On Mon, Apr 1, 2013 at 8:39 PM, Michael Blumenkrantz > >> <[email protected] <javascript:;>> wrote: > >> > On Mon, 1 Apr 2013 20:26:09 +0900 > >> > Daniel Juyung Seo <[email protected] <javascript:;>> wrote: > >> > > >> >> Quick review. > >> >> > >> >> 1. formatting fix. > >> >> 2. api name suggestion. > >> >> elm_scrollable_interface_event_rect_repeat_events_set()? > >> > > >> > can we try to avoid api names like this? in elementary and other libs. > >> super descriptive api names are pointless if they're so long that nobody > >> wants to type them, and descriptions are what docs are for. > >> > >> 1. consider that this is internal function. suggest a better name > >> then. or everytime we develop efl(at least scrollable interface) we > >> have no idea what those apis do until we completely read the docs > >> everytime. > >> 2. grep with elm_scrollable_interface. > > > > > > couple of parts in that name are useless: 2 "event", 1 "rect". > > > > elm_scrollable_interface_repeat_events_set() should do. > > I know you already read the code and this does not explain exactly what it > does. > "elm_scrollable_interface_repeat_events_set()" sounds like > "elm_scrollable_interface" is repeating to the below layer objects. > (this is what evas_object_repeat_events_set does) > But it's not. > This API is to handle the event triggering between scrollerable > interface's INTERNAL objects. > > > > > but then I wonder if EO would make it possible to override the method > > evas_object_repeat_events_set(), reusing it for the scroller. > > > > Note: it shouldn't matter for the outside that the action is to be > applied > > over the event rectangle. It's the behavior that matters and not the > > implementation > > Yes but I still wonder this also explains the behavior exactly. > Anyhow I got your point that "API does not need to describe exactly > what it does, it describes just abstraction of what behavior we would > expect." > I can accept this idea. But I am still curious existing API explains > enough. > Correct me if I am wrong. > > Any kind of comments are welcomed to clean up elm apis. > > Daniel Juyung Seo (SeoZ) > > > > > > > > > > > -- > > Gustavo Sverzut Barbieri > > http://profusion.mobi embedded systems > > -------------------------------------- > > MSN: [email protected] <javascript:;> > > Skype: gsbarbieri > > Mobile: +55 (19) 9225-2202 > > > ------------------------------------------------------------------------------ > > Own the Future-Intel® Level Up Game Demo Contest 2013 > > Rise to greatness in Intel's independent game demo contest. > > Compete for recognition, cash, and the chance to get your game > > on Steam. $5K grand prize plus 10 genre and skill prizes. > > Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] <javascript:;> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ > Own the Future-Intel® Level Up Game Demo Contest 2013 > Rise to greatness in Intel's independent game demo contest. > Compete for recognition, cash, and the chance to get your game > on Steam. $5K grand prize plus 10 genre and skill prizes. > Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d > _______________________________________________ > enlightenment-devel mailing list > [email protected] <javascript:;> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Own the Future-Intel® Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
