On Friday 17 May 2013 08:06, Carsten Haitzler wrote : > On Wed, 15 May 2013 07:22:42 -0700 Jérémy Zurcher - Enlightenment Git > <[email protected]> said: > > what is the librsvg version check for including rsvg-cairo.h meant to be > for? it doesn't work. are you trying to say that BEFORE 2.36.2 we HAD to > include rsvg-cairo.h ourselves, but as of this version we no longer need to > because rsvg automatically includes it? it's included from rsvg.h since ?? and deprecated since 2.36.2 http://upstream-tracker.org/diffs/librsvg/2.36.1_to_2.36.2/diff.html direct include of librsvg-features.h is deprecated too > > because... your check is broken, the ! in front does not.. work... looked good here … maybe because rsvg.h >= 2.36.2 provides librsvg-features.h thus LIBRSVG_CHECK_VERSION but if < 2.36.2 you have none => epic fail > > > jeyzu pushed a commit to branch master. > > > > commit 3912f569b0bf0771d4bcfc45e89c020aa5d10f44 > > Author: Jérémy Zurcher <[email protected]> > > Date: Wed May 15 16:22:24 2013 +0200 > > > > add glib-2 and librsvg version checks > > --- > > src/bin/svg/main.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/src/bin/svg/main.c b/src/bin/svg/main.c > > index 366fe60..89a48fa 100644 > > --- a/src/bin/svg/main.c > > +++ b/src/bin/svg/main.c > > @@ -8,7 +8,9 @@ > > #include <Eina.h> > > > > #include <librsvg/rsvg.h> > > +#if !LIBRSVG_CHECK_VERSION(2,36,2) > > #include <librsvg/rsvg-cairo.h> > > +#endif > > > > #define DATA32 unsigned int > > > > @@ -57,7 +59,9 @@ static int > > _svg_init(const char *file) > > { > > #ifdef HAVE_SVG_2_36 > > +# if !defined(GLIB_VERSION_2_36) > > g_type_init(); > > +# endif > > #else > > rsvg_init(); > > #endif > > > > -- > > > > ------------------------------------------------------------------------------ > > AlienVault Unified Security Management (USM) platform delivers complete > > security visibility with the essential security capabilities. Easily and > > efficiently configure, manage, and operate all of your security controls > > from a single console and one unified framework. Download a free trial. > > http://p.sf.net/sfu/alienvault_d2d > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] > > > ------------------------------------------------------------------------------ > AlienVault Unified Security Management (USM) platform delivers complete > security visibility with the essential security capabilities. Easily and > efficiently configure, manage, and operate all of your security controls > from a single console and one unified framework. Download a free trial. > http://p.sf.net/sfu/alienvault_d2d > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
-- Jérémy Zurcher av General Guisan 49 1400 Yverdon-les-bains +41 (0) 79 599 84 27 ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
