* Tom Hacohen <tom.haco...@samsung.com> [2013-05-22 17:20:32 +0100]: > On 22/05/13 16:43, Gustavo Lima Chaves wrote: > >This is addressed to Elementary coders, especially Tom and (Jack)Daniel. > > > >When I released the new, widget classes enabled version of Elementary, > >I introduced the scrollable widgets, as seen on picture > >http://docs.enlightenment.org/auto/elementary/elm-widget-tree.png. All > >those would respond to all elm_scroller_ namespaced EAPI functions, > >like explicitly said at that widget's documentation -- > > > >"Its (non-deprecated) API functions, except for elm_scroller_add(), > >which gives basic scroller objects, are meant to be a basis for all > >other scrollable widgets (i.e. widgets implementing The Elementary > >Scrollable Interface). So, they will work both on pristine scroller > >widgets and on other "specialized" scrollable widgets." > > > >What happened after people stepped in to translate the Evas Smart > >Class based inheritance schema to eo, is that some of those > >elm_scroller_ functions meant to work on all scrollables DO NOT > >ANYMORE (they work only for the scroller, itself). That is an ABI > >break, which can't go on released. > > > >Daniel, could you fix that for us, please? All elm_scroller.c EAPI > >functions which had s_iface-> calls on old elm and now have eo_do() > >for elm_obj_scroller_ namespaced things are WRONG, like: > > > >- elm_scroller_region_get > >- elm_scroller_child_size_get > >- elm_scroller_page_relative_set (_get is OK) > > > > I blame the lack of a test suite for the late discovery.
Agreed, and a bit of mis-review by me. But only some functions wrong is really hard to get. And being eo failures just console errors spits, how can an (existing) suite help us? > > -- > Tom. > -- Gustavo Lima Chaves Senior Developer @ ProFUSION Embedded Systems ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
