On Wed, May 22, 2013 at 4:54 AM, Hosang Kim - Enlightenment Git <no-re...@enlightenment.org> wrote: > seoz pushed a commit to branch master. > > commit c5c04e3d5a41f22a3a074b40adaef25b8f757aca > Author: Hosang Kim <hosang12....@samsung.com> > Date: Wed May 22 16:55:23 2013 +0900 > > [toolbar] fixed code for verification(ecore_job_add) > > make a pair for job event, check the event is alive before adding event. > --- > src/lib/elm_toolbar.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/lib/elm_toolbar.c b/src/lib/elm_toolbar.c > index d7e83f7..37f8287 100644 > --- a/src/lib/elm_toolbar.c > +++ b/src/lib/elm_toolbar.c > @@ -736,8 +736,8 @@ _resize_cb(void *data, > evas_object_geometry_get(data, &x, &y, NULL, &h); > evas_object_move(sd->more, x, y + h); > > - if (!sd->resize_job) > - sd->resize_job = ecore_job_add(_resize_job, data); > + ELM_FREE_FUNC(sd->resize_job, ecore_job_del); > + sd->resize_job = ecore_job_add(_resize_job, data); > }
I didn't get the commit message, and what has been fixed. I don't even agree with this commit, why are you deleting an ecore_job just to create it again? Is there a good reason for this? -- Rafael Antognolli ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
