On Mon, 10 Jun 2013 12:43:50 +0100 Tom Hacohen <[email protected]> said:
> On 10/06/13 12:04, Carsten Haitzler (The Rasterman) wrote: > > On Mon, 10 Jun 2013 10:58:12 +0100 Tom Hacohen <[email protected]> > > said: > > > >> I know they are not the same. However I don't see how getting the font's > >> bounding box (what's done in the max ascent/descent functions) is any > >> better than getting the font's requested ascent/descent. > >> > >> What issue have you noticed? > > > > my titlebars in e17 got thinner after that commit. > > > >> The bounding box looked wayyyy too big, that's why I adjusted that. Do > >> you have any reference to why getting the font's bounding box and > >> calculating according to that is better? > > > > you set the ascent and descent TO max_ascent AND max_descent. which is > > wrong. max_* are the full outer bounds of the font. the font can draw UP to > > these. actual ascent and descent can and often ARE smaller than the fonts > > bounding which results in CLIPPING of the text/font. that is why there are > > specific queries for ascent, descent AND max ascent AND max descent. so you > > can choose what to do by specifically placing/laying out the object. > > Oh yes, that I did mess up, because I was lazy. The problem though is > the object's sizing, that should probably not be the max ascent/descent > but the ascent descent. That, I think, won't solve your issue with the > title-bars anyway, so I don't see how it makes a difference. The only > thing that should matter is people asking for that explicitly. > > I did that commit the way I did to see if there'll be impacts that I > might have missed. Otherwise, I would have just removed the whole thing. > > The problem is that without my commit, text objects are badly sized and > align the text wrong, as the behaviour is different from textblock. well the original sizing of text objects was right given fontsets and the max bounds. if you want a sizing setup that makes these overflow pixels outside the obj.. it probably should be in edje as a layout option. tb has query calls to get these too. :) for the tb as a whole). -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. A cloud service to automate IT design, transition and operations 2. Dashboards that offer high-level views of enterprise services 3. A single system of record for all IT processes http://p.sf.net/sfu/servicenow-d2d-j _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
