2013/5/28 Davide Andreoli <d...@gurumeditation.it> > 2013/5/28 Rafael Antognolli <antogno...@gmail.com> > >> Hi, >> >> On Mon, May 27, 2013 at 6:01 PM, Davide Andreoli <d...@gurumeditation.it> >> wrote: >> > 2013/5/27 Davide Andreoli <d...@gurumeditation.it> >> > >> >> 2013/5/21 Nicolas Aguirre <aguirre.nico...@gmail.com> >> >> >> >>> Hi there, >> >>> please find attached a patch which introduce a new emotion API : >> >>> emotion_module_option_get, which retrieves the parameters set with >> >>> emotion_module_option_set. This patch also pass options to the engine. >> >>> It's usefull in case of VLC to give specific arguments for example, >> >>> the --no-video-title, it's annoying to have the name of the film >> >>> displayed at statup. >> >>> >> >>> I'm not sure this is the best thing we ca do here, but it' doesn't >> >>> break the "API" and it does the job, so please review. >> >>> >> >> >> >> I'm not sure either that is the right way to go, but I also really >> need to >> >> remove that annoying >> >> title on the movies. Do you have other options to pass or is just the >> >> title ? >> >> >> >> I think that the display of the title should be removed by default, no >> >> other engines >> >> have that and they should behave all the same way. So it should be >> easier >> >> to just put >> >> that option with the other defaults...but: >> >> >> >> The way we pass options to vlc is wrong. We pass args to libvlc_new(), >> the >> >> docs say: >> >> >> >> "There is absolutely no warranty or promise of forward, backward and >> >> cross-platform compatibility with regards to libvlc_new()< >> http://www.videolan.org/developers/vlc/doc/doxygen/html/group__libvlc__core.html#ga915aa5778053d7b52ff9f6ba6e2f7764>arguments. >> We recommend that you do not use them, other than when >> >> debugging." >> >> >> >> So I'm not sure that option is supported by other libvlc >> versions...ideas ? >> >> >> > >> > hmm, I tryed to remove all the args passed to libvlc_new, thus calling >> > libvlc_new(0, NULL) ... and everything seems to work fine, someone know >> > why we are passing that args? >> >> I think that it originally was needed to make libvlc render in a given >> memory buffer, but maybe it's not anymore. It seems that only >> libvlc_video_set_callbacks is necessary: >> >> >> http://www.videolan.org/developers/vlc/doc/doxygen/html/group__libvlc__media__player.html#ga612605f2e5c638d9f4ed59021d714bf0 >> >> Anyway, did you set them to NULL on Emotion, or in a test program? I >> don't see why not removing them if they are really not needed on >> Emotion... >> > > I set nulll in the vlc module (emotion_generic_vlc.c). > > In the mean time I searched around and everyone seems to pass args to > libvlc_new(), > also in some internal vlc examples. I came up with these args, that > everyone implementing > libvlc are using: > > const char *vlc_argv[] = > { > "--quiet", > "--intf", "dummy", /* no interface */ > "--vout", "dummy", /* we don't want video (output) */ > "--no-video-title-show", /* nor the filename displayed */ > "--no-sub-autodetect-file", /* we don't want subtitles */ > "--no-stats", /* no stats */ > "--no-inhibit", /* we don't want interfaces */ > "--no-disable-screensaver", /* we don't want interfaces */ > }; > > this seems to me a reasonable sets of params, the only one I'm not sure is: > --no-sub-autodetect-file. At the moment is not set and infact emotion > automatically display subtitles if a .srt file is found with the same name > as the movie. > IMO we must remove that automatic behavior, that works only with the vlc > engine. > App should be responsable of that, maybe the app want to display subs in a > different way. > > davemds >
no one seems against this, so I pushed the new set of options to git. cheers davemds > > >> >> Regards, >> -- >> Rafael Antognolli >> >> >> ------------------------------------------------------------------------------ >> Try New Relic Now & We'll Send You this Cool Shirt >> New Relic is the only SaaS-based application performance monitoring >> service >> that delivers powerful full stack analytics. Optimize and monitor your >> browser, app, & servers with just a few lines of code. Try New Relic >> and get this awesome Nerd Life shirt! >> http://p.sf.net/sfu/newrelic_d2d_may >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
