On 09/07/13 01:56, Cedric BAIL wrote: > On Mon, Jul 8, 2013 at 10:39 PM, Chris Michael - Enlightenment Git > <[email protected]> wrote: >> devilhorns pushed a commit to branch master. >> >> commit 6e49578cb779a26a8bebb61402facf99c1aa5341 >> Author: Chris Michael <[email protected]> >> Date: Mon Jul 8 14:38:54 2013 +0100 >> >> Check for valid string before trying to write (potentially NULL) to >> the pipe. >> >> NB: Fixes Coverity CID1039398 >> >> Signed-off-by: Chris Michael <[email protected]> >> --- >> src/modules/emotion/generic/emotion_generic.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/src/modules/emotion/generic/emotion_generic.c >> b/src/modules/emotion/generic/emotion_generic.c >> index 5706511..1819f53 100644 >> --- a/src/modules/emotion/generic/emotion_generic.c >> +++ b/src/modules/emotion/generic/emotion_generic.c >> @@ -108,7 +108,9 @@ _player_send_str(Emotion_Generic_Video *ev, const char >> *str, Eina_Bool stringsha >> len = str ? eina_stringshare_strlen(str) + 1 : 0; >> else >> len = str ? strlen(str) + 1 : 0; >> - ecore_pipe_write(ev->fd_write, str, len); >> + >> + if (str) >> + ecore_pipe_write(ev->fd_write, str, len); >> } > Not sure it was a real problem as len would have been zero in that case. > -- > Cedric BAIL I cannot argue with your logic ;) I would however say this ... Even tho it may not have been a "real" problem, does this commit Hurt anything ? I would say No ;)
dh ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
