On Fri, 19 Jul 2013 01:03:15 -0700 Mike Blumenkrantz - Enlightenment Git <no-re...@enlightenment.org> said:
> discomfitor pushed a commit to branch master. > > commit ea7bc3f670512eedf91578b2252ce59610bc316c > Author: Mike Blumenkrantz <m.blumenk...@samsung.com> > Date: Fri Jul 19 09:02:33 2013 +0100 > > revert e7862929e4aa5217b634f08dc7ea387781e157ea > > the ECORE_X_SYNC environment variable exists to make ecore-x debugging > synchronous. printing X errors as they occur is useful for application > developers; errors should not be silenced just because they are inconvenient > or plentiful. x errors happen all the time as a wm. you cannot get rid of them. it's part of race conditions dealing with resources from other clients. it happens to ALSO come along for apps in general if a window they were going to query vanishes along the way in between discovery and query. > --- > src/lib/ecore_x/xlib/ecore_x_error.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/src/lib/ecore_x/xlib/ecore_x_error.c > b/src/lib/ecore_x/xlib/ecore_x_error.c index eca7f1f..3695341 100644 > --- a/src/lib/ecore_x/xlib/ecore_x_error.c > +++ b/src/lib/ecore_x/xlib/ecore_x_error.c > @@ -102,55 +102,55 @@ _ecore_x_error_handle(Display *d, > switch (ev->error_code) > { > case BadRequest: /* bad request code */ > - DBG("BadRequest"); > + ERR("BadRequest"); > break; > case BadValue: /* int parameter out of range */ > - DBG("BadValue"); > + ERR("BadValue"); > break; > case BadWindow: /* parameter not a Window */ > - DBG("BadWindow"); > + ERR("BadWindow"); > break; > case BadPixmap: /* parameter not a Pixmap */ > - DBG("BadPixmap"); > + ERR("BadPixmap"); > break; > case BadAtom: /* parameter not an Atom */ > - DBG("BadAtom"); > + ERR("BadAtom"); > break; > case BadCursor: /* parameter not a Cursor */ > - DBG("BadCursor"); > + ERR("BadCursor"); > break; > case BadFont: /* parameter not a Font */ > - DBG("BadFont"); > + ERR("BadFont"); > break; > case BadMatch: /* parameter mismatch */ > - DBG("BadMatch"); > + ERR("BadMatch"); > break; > case BadDrawable: /* parameter not a Pixmap or Window */ > - DBG("BadDrawable"); > + ERR("BadDrawable"); > break; > case BadAccess: /* depending on context */ > - DBG("BadAccess"); > + ERR("BadAccess"); > break; > case BadAlloc: /* insufficient resources */ > - DBG("BadAlloc"); > + ERR("BadAlloc"); > break; > case BadColor: /* no such colormap */ > - DBG("BadColor"); > + ERR("BadColor"); > break; > case BadGC: /* parameter not a GC */ > - DBG("BadGC"); > + ERR("BadGC"); > break; > case BadIDChoice: /* choice not in range or already used */ > - DBG("BadIDChoice"); > + ERR("BadIDChoice"); > break; > case BadName: /* font or color name doesn't exist */ > - DBG("BadName"); > + ERR("BadName"); > break; > case BadLength: /* Request length incorrect */ > - DBG("BadLength"); > + ERR("BadLength"); > break; > case BadImplementation: /* server is defective */ > - DBG("BadImplementation"); > + ERR("BadImplementation"); > break; > } > if (d == _ecore_x_disp) > > -- > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel