I'm not sure this is entirely correct. This prints an error in 2 cases when it shouldn't:
* a call is canceled by the user (not an error in any case) * the call is canceled because you've deleted the object (in which case proxy->obj->name is NULL and the error is useless anyway) On Thu, Jul 25, 2013 at 6:28 PM, José Roberto de Souza - Enlightenment Git < [email protected]> wrote: > zehortigoza pushed a commit to branch master. > > commit cbd0ccbbbedf93eabef08cd42b71425368ebb983 > Author: José Roberto de Souza <[email protected]> > Date: Thu Jul 25 14:22:10 2013 -0300 > > eldbus: Check if property_get_all() returned a error before read > properties > --- > src/lib/eldbus/eldbus_proxy.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/src/lib/eldbus/eldbus_proxy.c b/src/lib/eldbus/eldbus_proxy.c > index 675c510..c0fceef 100644 > --- a/src/lib/eldbus/eldbus_proxy.c > +++ b/src/lib/eldbus/eldbus_proxy.c > @@ -732,6 +732,14 @@ _props_get_all(void *data, const Eldbus_Message *msg, > Eldbus_Pending *pending EI > { > Eldbus_Proxy *proxy = data; > Eldbus_Message_Iter *dict; > + const char *name, *error_msg; > + > + if (eldbus_message_error_get(msg, &name, &error_msg)) > + { > + ERR("Error getting all properties of %s %s, error message: %s %s", > + proxy->obj->name, proxy->obj->path, name, error_msg); > + return; > + } > > if (!eldbus_message_arguments_get(msg, "a{sv}", &dict)) > { > > ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
