On Mon, Sep 2, 2013 at 4:16 PM, José Roberto de Souza - Enlightenment
Git <no-re...@enlightenment.org> wrote:
> zehortigoza pushed a commit to branch master.
>
> commit bcba4779c8df1efe950b5f4cc1075187ab365a57
> Author: José Roberto de Souza <jose.so...@intel.com>
> Date: Fri Aug 30 10:52:04 2013 -0300
>
> eldbus: Add timeout message error as a macro
> ---
> src/lib/eldbus/Eldbus.h | 1 +
> src/lib/eldbus/eldbus_pending.c | 8 ++++----
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/src/lib/eldbus/Eldbus.h b/src/lib/eldbus/Eldbus.h
> index e49061d..fe05f2e 100644
> --- a/src/lib/eldbus/Eldbus.h
> +++ b/src/lib/eldbus/Eldbus.h
> @@ -126,6 +126,7 @@ extern "C" {
> #define ELDBUS_FDO_INTERFACE_INTROSPECTABLE
> "org.freedesktop.DBus.Introspectable"
> #define ELDBUS_FDO_INTEFACE_PEER "org.freedesktop.DBus.Peer"
> #define ELDBUS_ERROR_PENDING_CANCELED "org.enlightenment.DBus.Canceled"
> +#define ELDBUS_ERROR_PENDING_TIMEOUT "org.enlightenment.DBus.Timeout"
I wonder why we are defining this in a public header with the
org.enlightenment namespace when there's a fdo one.
>
> typedef struct _Eldbus_Version
> {
> diff --git a/src/lib/eldbus/eldbus_pending.c b/src/lib/eldbus/eldbus_pending.c
> index 4174ac1..bf561bb 100644
> --- a/src/lib/eldbus/eldbus_pending.c
> +++ b/src/lib/eldbus/eldbus_pending.c
> @@ -51,8 +51,8 @@ cb_pending(DBusPendingCall *dbus_pending, void *user_data)
> INF("timeout to pending %p", pending);
> dbus_pending_call_cancel(dbus_pending);
> msg = eldbus_message_error_new(pending->msg_sent,
> - "org.enlightenment.DBus.Timeout",
> - "This call was not completed.");
> + ELDBUS_ERROR_PENDING_TIMEOUT,
> + "This call was not completed in
> time.");
And here I think we would be better off using
org.freedesktop.DBus.Error.NoReply instead of timeout. I think the
timeout would be used by an *application* when the operation it's
doing timed out.
Lucas De Marchi
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
