First, you added without any notice to me. And second, if you really think so, then don't add the comment but argue it to remove.
Thanks. ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Daniel Juyung Seo"<seojuyu...@gmail.com> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2013-09-03 (화) 18:44:54 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: core/elementary - please just mention the fact itself not relative. On Tue, Sep 3, 2013 at 6:15 PM, Tom Hacohen <tom.hacohen>@samsung.com> wrote: > I don't get the point of arguing about the documentation of an API that > should not be there in the first place. > True. That's is why I wanted to put strong warning. And the warning is removed by hermet without any notice to me. Daniel Juyung Seo (SeoZ) > > -- > Tom. > > On 03/09/13 10:09, Daniel Juyung Seo wrote: > > No, this is important because it is evil. > > We even have comments like: > > 1. > > * DO NOT use this function unless you are the person God comes to ask for > > * advice when He has trouble managing the Universe. > > > > 2. > > /* DO NOT USE THIS HEADER UNLESS YOU ARE PREPARED FOR BREAKING OF YOUR > > * CODE. THIS IS ELEMENTARY'S INTERNAL WIDGET API (for now) AND IS NOT > > * FINAL. CALL elm_widget_api_check(ELM_INTERNAL_API_VERSION) TO CHECK > > * IT AT RUNTIME. > > > > Current warning is not enough. > > Thanks. > > > > Daniel Juyung Seo (SeoZ) > > > > > > On Tue, Sep 3, 2013 at 2:11 PM, ChunEon Park - Enlightenment Git < > > no-re...@enlightenment.org> wrote: > > > >> hermet pushed a commit to branch master. > >> > >> commit 790d18b0f5915026ebc558ed5e62435288e0a463 > >> Author: ChunEon Park <hermet>@hermet.pe.kr> > >> Date: Tue Sep 3 14:08:17 2013 +0900 > >> > >> core/elementary - please just mention the fact itself not relative. > >> --- > >> src/lib/elm_object_item.h 13 ++++++------- > >> 1 file changed, 6 insertions(+), 7 deletions(-) > >> > >> diff --git a/src/lib/elm_object_item.h b/src/lib/elm_object_item.h > >> index e7bd25f..1d9f490 100644 > >> --- a/src/lib/elm_object_item.h > >> +++ b/src/lib/elm_object_item.h > >> @@ -39,13 +39,12 @@ EAPI Evas_Object > >> *elm_object_item_widget_get(const Elm_Object_It > >> * @param it The Elementary object item > >> * @return The Internal object of the object item. > >> * > >> - * @note THIS API NEEDS TO BE USED WITH GREAT CONSIDERATION. This > function > >> - * should only be used if you really need to refer the internal > object's > >> - * properties (i.e geometry). Since the object items are > >> managed/controlled by > >> - * the widget, the object could be deleted, resized, moved and so on by > >> the > >> - * widget. So you should not modify the object directly nor you should > not > >> - * treat the object without validation, we don't guarantee the result > of > >> any of > >> - * these behavior. > >> + * @note This function should only be used if you really need to refer > the > >> + * internal object's properties (i.e geometry). Since the object items > are > >> + * managed/controlled by the widget, the object could be deleted, > >> resized, moved > >> + * and so on by the widget. So you should not modify the object > directly > >> nor you > >> + * should not treat the object without validation, we don't guarantee > the > >> result > >> + * of any of these behavior. > >> * > >> * Some widget items may return @c NULL for this API if the items @p > are > >> not > >> * based on the evas object. > >> > >> -- > >> > >> > >> > ------------------------------------------------------------------------------ > >> Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > >> Discover the easy way to master current and previous Microsoft > technologies > >> and advance your career. Get an incredible 1,500+ hours of step-by-step > >> tutorial videos with LearnDevNow. Subscribe today and save! > >> > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > >> > > > ------------------------------------------------------------------------------ > > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > > Discover the easy way to master current and previous Microsoft > technologies > > and advance your career. Get an incredible 1,500+ hours of step-by-step > > tutorial videos with LearnDevNow. Subscribe today and save! > > > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > ------------------------------------------------------------------------------ > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
