Well, I just realized "access_text" was added in elementary 1.7 and this is
a theme api break.
So what we can do is:
1. Support both "access_text" and "access.txt" for backport support. But
code gets dirty.
2. Break theme API. I guess this access text was introduced right before
1.7 release and would not be used that much. As we allow theme API break
for some exceptional cases, it's the last chance to fix wrong thing.
Daniel Juyung Seo (SeoZ)
On Sat, Sep 7, 2013 at 11:56 AM, Shinwoo Kim - Enlightenment Git <
no-re...@enlightenment.org> wrote:
> kimcinoo pushed a commit to branch master.
>
> commit e74b8896c5eb37609d8a829e6c1f978c29012a05
> Author: Shinwoo Kim <cinoo....@samsung.com>
> Date: Sat Sep 7 11:56:11 2013 +0900
>
> [spinner] change part name to access.text from access_text for naming
> consistency
> ---
> NEWS | 1 +
> data/themes/widgets/spinner.edc | 12 ++++++------
> src/lib/elm_spinner.c | 6 +++---
> 3 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index c6046bd..30d5df0 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -275,6 +275,7 @@ Fixes:
> imf is available, the keyboard mode should be decided by ime, but not
> entry.
> This prevents the asynchronous states between ime and conformant.
> * Flip : Fix the flip page to not flip on a direction if the direction
> is disabled.
> + * Spinner : change part name to access.text from access_text on
> default style.
>
> Removals:
>
> diff --git a/data/themes/widgets/spinner.edc
> b/data/themes/widgets/spinner.edc
> index ac518e1..3edad88 100644
> --- a/data/themes/widgets/spinner.edc
> +++ b/data/themes/widgets/spinner.edc
> @@ -355,7 +355,7 @@ group { name: "elm/spinner/base/default";
> visible: 1;
> }
> }
> - part { name: "access_text";
> + part { name: "access.text";
> type: RECT;
> repeat_events: 1;
> description { state: "default" 0.0;
> @@ -518,7 +518,7 @@ group { name: "elm/spinner/base/default";
> target: "right_over1";
> target: "right_over2";
> target: "disabler";
> - target: "access_text";
> + target: "access.text";
> after: "disable_text";
> }
> program { name: "disable_text";
> @@ -549,7 +549,7 @@ group { name: "elm/spinner/base/default";
> target: "right_over1";
> target: "right_over2";
> target: "disabler";
> - target: "access_text";
> + target: "access.text";
> after: "enable_text";
> }
> program { name: "enable_text";
> @@ -908,7 +908,7 @@ group { name: "elm/spinner/base/vertical";
> visible: 1;
> }
> }
> - part { name: "access_text";
> + part { name: "access.text";
> type: RECT;
> repeat_events: 1;
> description { state: "default" 0.0;
> @@ -993,7 +993,7 @@ group { name: "elm/spinner/base/vertical";
> target: "down_bt";
> target: "up_bt";
> target: "disabler";
> - target: "access_text";
> + target: "access.text";
> after: "disable_text";
> }
> program { name: "disable_text";
> @@ -1020,7 +1020,7 @@ group { name: "elm/spinner/base/vertical";
> target: "down_bt";
> target: "up_bt";
> target: "disabler";
> - target: "access_text";
> + target: "access.text";
> after: "enable_text";
> }
> program { name: "enable_text";
> diff --git a/src/lib/elm_spinner.c b/src/lib/elm_spinner.c
> index 5861c04..1afe98b 100644
> --- a/src/lib/elm_spinner.c
> +++ b/src/lib/elm_spinner.c
> @@ -614,7 +614,7 @@ _access_spinner_register(Evas_Object *obj, Eina_Bool
> is_access)
> (obj, elm_layout_edje_get(obj), decrement_part);
>
> _elm_access_edje_object_part_object_unregister
> - (obj, elm_layout_edje_get(obj), "access_text");
> + (obj, elm_layout_edje_get(obj), "access.text");
>
> return;
> }
> @@ -639,7 +639,7 @@ _access_spinner_register(Evas_Object *obj, Eina_Bool
> is_access)
>
> /* register spinner label */
> ao = _elm_access_edje_object_part_object_register
> - (obj, elm_layout_edje_get(obj), "access_text");
> + (obj, elm_layout_edje_get(obj), "access.text");
>
> ai = _elm_access_info_get(ao);
> _elm_access_text_set(ai, ELM_ACCESS_TYPE, E_("spinner"));
> @@ -797,7 +797,7 @@ _elm_spinner_smart_focus_next(Eo *obj, void *_pd
> EINA_UNUSED, va_list *list)
> decrement_part = "left_bt";
> }
>
> - ao = _access_object_get(obj, "access_text");
> + ao = _access_object_get(obj, "access.text");
> items = eina_list_append(items, ao);
>
> ao = _access_object_get(obj, decrement_part);
>
> --
>
>
> ------------------------------------------------------------------------------
> Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
> Discover the easy way to master current and previous Microsoft technologies
> and advance your career. Get an incredible 1,500+ hours of step-by-step
> tutorial videos with LearnDevNow. Subscribe today and save!
> http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
>
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
