On Fri, 6 Sep 2013 19:09:43 -0300 Gustavo Sverzut Barbieri <barbi...@gmail.com> said:
> On Fri, Sep 6, 2013 at 4:01 PM, Jose Souza <zehortig...@profusion.mobi> wrote: > > I just push elm_app_server/client classes in elementary and the > > implementation of they in terminology. > > > > http://git.enlightenment.org/core/elementary.git/log/?h=devs/zehortigoza/app_spec_impl > > > > http://git.enlightenment.org/apps/terminology.git/log/?h=devs/zehortigoza/app_spec_impl > > nice! I'll have a try and recommend the others to do the same. I did > review the code already, looks nice! I'd kindly ask more people to > review otherwise merge it in 7 days i looked at the terminology code right now... it seems quite a LOT of code. i do realize that most of it seems devoted to handling restoring a terminal that has had its window destroyed entirely - restoring backlog even too. but it does this by creating a new pty then loading backlog. i don't think that's very viable. as long as a backlog wants to be restored, i think that actually what has to happen is the pty needs to be split off from the object that holds it on del of the obj) and thus put into some kind of hibernate mode inside the process. sure backlog can be dumped right to disk and then forgotten from memory, and the pty fd's can simply be removed from the mainloop fd handlers, thus effectively suspending the entire pty (any process running inside will soon enough block when buffers fill up as terminology no longer is reading the pty fd). of course these "still open fd's but not being listened to" need to be stored in a list somewhere, so they still use some minimal resources, BUT they can be very close to "zero mem+cpu". but doing it the current way is just going to create some half-broken pty with backscroll not matching the pty state/content etc. (shell history not right, etc. etc.). so my reading of this makes me thing 2 ways. 1. either do this fully right (as above) OR, 2. remove the code handling window deletion and restoration, thus cutting down the code massively. it'll be much simpler then. :) thoughts? > > -- > Gustavo Sverzut Barbieri > -------------------------------------- > Mobile: +55 (19) 9225-2202 > Contact: http://www.gustavobarbieri.com.br/contact > > ------------------------------------------------------------------------------ > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
