On Thu, 12 Sep 2013 14:45:57 +0900 (KST) ChunEon Park <her...@naver.com> said:

^  ^
O  O
 ..
\__/

> Hi, 
> 
> I reverted elm_object_item_get() API.
> 
> Cedric, Raster, Daniel, Me together discussed for more proper way instead of
> the API. In the end, Cedric suggested to return the rectangle object that's a
> kind of fake object of the object item's real object. and All of us agreed on
> it.
> 
> Now, I will add 2 more APIs elm_object_item_object_track(),
> elm_object_item_object_untrack() to return/retrieve the fake object. 
> 
> Maybe, all guys will be happy with these APis.
> 
> If you have some other idea or whatever opinions, please reply on this email.
> 
> Thank you.
>  
> ------------------------------------
> -Regards, Hermet- 
> 
> -----Original Message-----
> From: "ChunEon Park - Enlightenment Git"<no-re...@enlightenment.org> 
> To: <enlightenment-...@lists.sourceforge.net>; 
> Cc: 
> Sent: 2013-09-12 (목) 14:15:15
> Subject: [EGIT] [core/elementary] master 01/01: elementary - revert
> ddc3cf80ce0a50a9161fcb212d3414f5d7b5898c
> 
> hermet pushed a commit to branch master.
> 
> commit 9558537385f0a402b1725076b7a6ea1c540fd39a
> Author: ChunEon Park <hermet>@hermet.pe.kr>
> Date:   Thu Sep 12 14:13:59 2013 +0900
> 
>     elementary - revert ddc3cf80ce0a50a9161fcb212d3414f5d7b5898c
>     
>     We have a plan to add more proper API.
> ---
>  ChangeLog                   4 ----
>  NEWS                        1 -
>  src/lib/elm_main.c          6 ------
>  src/lib/elm_object_item.h  21 ---------------------
>  src/lib/elm_widget.c        7 -------
>  src/lib/elm_widget.h        1 -
>  6 files changed, 40 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index c06f86f..ff18f8c 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1582,10 +1582,6 @@
>  
>          * Bg: Add bg reset feature.
>  
> -2013-09-02  ChunEon Park (Hermet)
> -
> -        * Widget: Introduce elm_object_item_object_get() API.
> -
>  2013-09-04  Ryuan Choi (ryuan)
>  
>          * elm_config : profile may be broken when clicked reset button in
> profiles tab diff --git a/NEWS b/NEWS
> index 5cb62b2..3d536c0 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -85,7 +85,6 @@ Additions:
>     * Add elm_win_focus_highlight_animate_set/get().
>     * Add selectraise feature to gengrid.
>     * Add bg reset feature.
> -   * Add elm_object_item_object_get().
>     * Add support for more than one progress status in a progressbar.
>     * Add elm_table_child_get().
>     * Add support for flip focus direction.
> diff --git a/src/lib/elm_main.c b/src/lib/elm_main.c
> index 6c8aba8..17654c6 100644
> --- a/src/lib/elm_main.c
> +++ b/src/lib/elm_main.c
> @@ -1899,9 +1899,3 @@ elm_object_item_cursor_engine_only_get(const
> Elm_Object_Item *it) {
>     return elm_widget_item_cursor_engine_only_get(it);
>  }
> -
> -EAPI const Evas_Object *
> -elm_object_item_object_get(const Elm_Object_Item *it)
> -{
> -   return _elm_widget_item_object_get((Elm_Widget_Item*)it);
> -}
> diff --git a/src/lib/elm_object_item.h b/src/lib/elm_object_item.h
> index 1d9f490..8a0ccde 100644
> --- a/src/lib/elm_object_item.h
> +++ b/src/lib/elm_object_item.h
> @@ -34,27 +34,6 @@ typedef void                  (*Elm_Object_Item_Signal_Cb)
> (void *data, Elm_Objec EAPI Evas_Object
> *elm_object_item_widget_get(const Elm_Object_Item *it); 
>  /**
> - * Get the object item's internal object handle.
> - *
> - * @param it The Elementary object item
> - * @return The Internal object of the object item.
> - *
> - * @note This function should only be used if you really need to refer the
> - * internal object's properties (i.e geometry). Since the object items are
> - * managed/controlled by the widget, the object could be deleted, resized,
> moved
> - * and so on by the widget. So you should not modify the object directly nor
> you
> - * should not treat the object without validation, we don't guarantee the
> result
> - * of any of these behavior.
> - *
> - * Some widget items may return @c NULL for this API if the items @p are not
> - * based on the evas object.
> - *
> - * @since 1.8
> - * @ingroup General
> - */
> -EAPI const Evas_Object           *elm_object_item_object_get(const
> Elm_Object_Item *it); -
> -/**
>   * Set a content of an object item
>   *
>   * @param it The Elementary object item
> diff --git a/src/lib/elm_widget.c b/src/lib/elm_widget.c
> index 71953ce..c94f894 100644
> --- a/src/lib/elm_widget.c
> +++ b/src/lib/elm_widget.c
> @@ -5787,13 +5787,6 @@ _elm_widget_item_translate(Elm_Widget_Item *item)
>  #endif
>  }
>  
> -EAPI const Evas_Object *
> -_elm_widget_item_object_get(const Elm_Widget_Item *item)
> -{
> -   ELM_WIDGET_ITEM_CHECK_OR_RETURN(item, NULL);
> -   return item->view;
> -}
> -
>  /* happy debug functions */
>  #ifdef ELM_DEBUG
>  static void
> diff --git a/src/lib/elm_widget.h b/src/lib/elm_widget.h
> index e4d6362..48d8736 100644
> --- a/src/lib/elm_widget.h
> +++ b/src/lib/elm_widget.h
> @@ -771,7 +771,6 @@ EAPI void
> _elm_widget_item_domain_translatable_part_text_set(Elm_Wid EAPI const char
> *     _elm_widget_item_translatable_part_text_get(const Elm_Widget_Item
> *item, const char *part); EAPI void             _elm_widget_item_translate
> (Elm_Widget_Item *item); EAPI void
> _elm_widget_item_domain_part_text_translatable_set(Elm_Widget_Item *item,
> const char *part, const char *domain, Eina_Bool translatable); -EAPI const
> Evas_Object *_elm_widget_item_object_get(const Elm_Widget_Item *item); /**
>   * Function to operate on a given widget's scrollabe children when necessary.
> 
> -- 
> 
> ------------------------------------------------------------------------------
> How ServiceNow helps IT people transform IT departments:
> 1. Consolidate legacy IT systems to a single system of record for IT
> 2. Standardize and globalize service processes across IT
> 3. Implement zero-touch automation to replace manual, redundant tasks
> http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
> 
> ------------------------------------------------------------------------------
> How ServiceNow helps IT people transform IT departments:
> 1. Consolidate legacy IT systems to a single system of record for IT
> 2. Standardize and globalize service processes across IT
> 3. Implement zero-touch automation to replace manual, redundant tasks
> http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. Consolidate legacy IT systems to a single system of record for IT
2. Standardize and globalize service processes across IT
3. Implement zero-touch automation to replace manual, redundant tasks
http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to