On Tue, Sep 17, 2013 at 1:18 AM, Tom Hacohen <tom.haco...@samsung.com>wrote:
> On 16/09/13 17:11, Daniel Juyung Seo - Enlightenment Git wrote: > > seoz pushed a commit to branch master. > > > > commit 794c7825a52bd767482a4353f4af45bddac967bb > > Author: Daniel Juyung Seo <seojuyu...@gmail.com> > > Date: Sat Sep 14 13:31:32 2013 +0900 > > > > elm_list.c: disable edje_object_parts_extends_calc in _item_fix. > > > > This fixed T179 but introduced T286. T286 is bigger and more > important issue than T179. > > So temporarily disable these lines until it gets fixed correctly. > > In the future, please use "git revert". Manually reverting changes > (removal of the "Evas_Coord ew, eh;" line) is error-prone. Commenting > out code is in most cases bad and an almost guaranteed recipe for cruft. > "git revert" solves both, with the addition of referencing the original > commit that introduced the bug; thus explaining what that commit was > meant to achieve. > > Thanks for the interest. Actually I am a big fan of git revert but I didn't use it for this commit on purpose. That was just because this was not a "revert" but just a "temporary disable" and not to forget it. I asked the author of this code to fix it for weeks and it needs to be fixed. Maybe I should have added "FIXME". Just reverting may have higher possibility of forgetting things. And about the error-prone, I know this code well so I commented out manually to explicitly leave the code there. Thanks for the advice but please understand that this was not a mistake and it was done on purpose. So... fix it Thiep :) Daniel Juyung Seo (SeoZ) -- > Tom. > > > > ------------------------------------------------------------------------------ > LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! > 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, > SharePoint > 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack > includes > Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. > http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
